Fix race condition within HandleWorkflowError
#1795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
May 13, 2024
Also adds a more sensible caption to the error dialog when non-workflow errors occur.
PathogenDavid
force-pushed
the
building-race-fix
branch
from
0fc8152
to
04b6534
Compare
|
Converting to a draft for now as this shouldn't be merged. Will leave a more detailed comment on #1796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed while Gonçalo and I were investigating #1796
Also adds a more sensible caption to the error dialog when non-workflow errors occur.
I considered adding a message to the error encouraging people to report the error since we don't expect bare non-workflow exceptions to escape to this point, but the part of my brain responsible for wording things is already running on fumes as I get all these issues out of my head before the weekend 😅