Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call-stack based AST traversal code with heap-stack based traversal #711

Open
keyboardDrummer opened this issue Mar 30, 2023 · 3 comments · May be fixed by #709
Open

Replace call-stack based AST traversal code with heap-stack based traversal #711

keyboardDrummer opened this issue Mar 30, 2023 · 3 comments · May be fixed by #709
Labels
bug

Comments

@keyboardDrummer
Copy link
Collaborator

keyboardDrummer commented Mar 30, 2023 •
edited
Loading

We current use threads with very large stack sizes to prevent getting a stack overflow when traversing deep ASTs. However, it would be better to change these traversals so they don't use the call-stack for going into nested code.

The test nesting.bpl triggers some traversals of deeply nested code, and without using large stacks this test fails to pass.

PR #709 is a WIP attempt at using a stack on the heap
@keyboardDrummer keyboardDrummer mentioned this issue Mar 30, 2023
Merged
@shazqadeer
Copy link
Contributor

I am trying to understand the connection between the two pull requests #710 and #709 . Is #710 a temporary measure which would become unnecessary once #709 lands?

@keyboardDrummer
Copy link
Collaborator Author

keyboardDrummer commented Mar 30, 2023 •
edited
Loading

If #709 lands, #710 would become obsolete yes. However, I'm not sure when I'll have time to finish #709.

@keyboardDrummer keyboardDrummer mentioned this issue May 30, 2023
Open
@keyboardDrummer keyboardDrummer linked a pull request Apr 25, 2024 that will close this issue
Draft
@keyboardDrummer keyboardDrummer mentioned this issue May 21, 2024
Open
@keyboardDrummer
Copy link
Collaborator Author

keyboardDrummer commented May 21, 2024 •
edited
Loading

Same issue, albeit with different information: dafny-lang/dafny#5471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic stack keyboardDrummer/boogie
2 participants
@keyboardDrummer @shazqadeer