Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom install and build commands #38

Open
timrbula opened this issue Jan 31, 2023 · 3 comments
Open

Support custom install and build commands #38

timrbula opened this issue Jan 31, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@timrbula
Copy link
Member

Is your request related to a problem? Please describe.

I would like to run pnpm install --production and pnpm build:styles in my build process

Describe the solution you'd like

I would like to be able to specify custom commands to be run for installing dependencies and building the application e.g. build.install.script and build.script

Describe the benefits or justification for this request

I won't have to fallback to using Docker for building w/ custom commands

Additional context
Add any other context or screenshots about the feature request here.

@timrbula timrbula added the enhancement New feature or request label Jan 31, 2023
@timrbula
Copy link
Member Author

Build script has been completed w/ #50

@timrbula
Copy link
Member Author

timrbula commented Apr 11, 2023

@gchickma Would be good to do install script as well one day. You can configured basically everything via a project .npmrc file, but I don't think most teams know that.

That being said if your app needs specific install flags (there are ones that are commonly used to ignore peer dependency issues, among others) then they should probably have that defined so devs don't need to know the magic combination to get the app to run locally. So that would be an opportunity to do some best practices education, but we should probably still provide the functionality via a property.

@gchickma
Copy link
Member

@timrbula Sounds good. Lets look at that when we both have some time to work thru it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants