From 87f36385b406c0cc0238fb12cf9e48fed9044cbb Mon Sep 17 00:00:00 2001 From: dpomier Date: Fri, 19 Feb 2021 15:29:26 +0100 Subject: [PATCH 1/2] avoid unspecified behavior of Std.parseInt --- com/smartfoxserver/v2/requests/GenericMessageRequest.hx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/com/smartfoxserver/v2/requests/GenericMessageRequest.hx b/com/smartfoxserver/v2/requests/GenericMessageRequest.hx index 2266780..aa12b9c 100644 --- a/com/smartfoxserver/v2/requests/GenericMessageRequest.hx +++ b/com/smartfoxserver/v2/requests/GenericMessageRequest.hx @@ -168,8 +168,12 @@ class GenericMessageRequest extends BaseRequest if(_message==null || _message.length==0) errors.push("Buddy message is empty!"); - - var recipientId:Int = Std.parseInt(_recipient); + + var recipientId:Int = switch Std.parseInt("" + _recipient) { + case null: 0; + case v: v; + } + if(recipientId<0) errors.push("Recipient is not online or not in your buddy list"); } From 8db5645c542df5dd5cc16855c923a980d227a8af Mon Sep 17 00:00:00 2001 From: dpomier Date: Fri, 19 Feb 2021 15:33:19 +0100 Subject: [PATCH 2/2] make getInt parse only when necessary --- com/smartfoxserver/v2/entities/data/SFSObject.hx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/com/smartfoxserver/v2/entities/data/SFSObject.hx b/com/smartfoxserver/v2/entities/data/SFSObject.hx index e1f8031..1a88057 100644 --- a/com/smartfoxserver/v2/entities/data/SFSObject.hx +++ b/com/smartfoxserver/v2/entities/data/SFSObject.hx @@ -273,13 +273,16 @@ class SFSObject implements ISFSObject var wrapper:SFSDataWrapper = cast dataHolder[key]; if(wrapper != null) { + #if (js || flash) + return wrapper.data; + #else var value:Dynamic = wrapper.data; if(Std.is(value, Int)) { return value; } - value = Std.parseInt(value); - return value; + return Std.parseInt(""+value); + #end }else{ return 0; //==0 }