Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary JSON format for config coming from AWS Secrets Manager #12

Open
andrus opened this issue Oct 13, 2021 · 0 comments
Open

Comments

@andrus
Copy link
Contributor

andrus commented Oct 13, 2021

Currently AwsSecretFactory supports secrets format that is a JSON object with no nesting (i.e. {"a":"b","c":"d"}). No arrays or nested JSON structures are supported. This assumption works well for standard AWS secret choices (RDS, etc.), but severely limits custom configurations. Still need to support "mergePath" of course.

As a part of implementation we need to create an alternative to InPlacePropertiesMerger (currently used by AwsSecretFactory) that supports proper JSON merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant