Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review IntegrityErrors, especially when they kill #2444

Closed
ThomasWaldmann opened this issue Apr 25, 2017 · 1 comment · Fixed by #8332
Closed

review IntegrityErrors, especially when they kill #2444

ThomasWaldmann opened this issue Apr 25, 2017 · 1 comment · Fixed by #8332
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Apr 25, 2017

at some places (borg check --repair) we kill repository objects when we encounter IntegrityErrors on them.

for many cases this is the right thing to do - if an object is corrupt, it is not useful any more.

but when reading the LoggedIO code, i got the impression that some of the IEs raised there could be due to:

https://www.bountysource.com/issues/44509028-review-integrityerrors-especially-when-they-kill

@ThomasWaldmann ThomasWaldmann added this to the 1.1.0b6 milestone Apr 25, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.0b7, 1.1.0b6 Jun 2, 2017
@ThomasWaldmann ThomasWaldmann self-assigned this Jun 6, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.0b6, 1.1.0b7 Jun 10, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.0rc1, 1.1.0b6 Jun 17, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1 - near future goals, 1.1.0rc1 Jul 22, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.x, 1.1.0 release Sep 2, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.1rc1, 1.1.2rc1 Oct 14, 2017
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.1.2rc1, 1.1.x Nov 4, 2017
@ThomasWaldmann ThomasWaldmann removed their assignment Mar 20, 2018
@ThomasWaldmann
Copy link
Member Author

some work (mostly adding comments) was done in #2691 (but was not merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants