-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eigen compilation issue #940
Comments
Could you show the full command line of the failing file? i.e. the last big fat line when doing |
|
The comment on the pull request I mentioned earlier (this: #391 (comment)) said that this issue was only with c++17, so I ran the compile command I commented earlier with an added |
Ah! It must be a new issue with g++11.2 From here:
So this is gonna become a real issue for most users if they get the latest g++ but not the latest Eigen3... |
Oh I encountered this exact issue and have proposed a fix to it here #944 |
There is a catch here: most people will use system Eigen which is not 3.3.9. I would suggest we do some kind of work-around in our code instead. |
The workaround isn't something we can do trivially. We can use CMake to force 3.3.9 and this shouldn't be a major issue since it is a patch version update. |
Cool! I still think we should update eigen since there are other big fixes that we can benefit from. Asking users to update eigen is a small task for the rewards. |
@varunagrawal upgrading system eigen is not trivial so I vote to work-around in our code. Please update PR #944 with other reasons to upgrade. Please do not merge until serialization is validated with old Eigen version. |
Okay, I am updating #944 with the workaround that Fan linked. |
Huh @ProfFan that fix doesn't work. I am getting the error
|
Also, maintainers of Eigen also call it an "ugly hack" https://gitlab.com/libeigen/eigen/-/issues/1676#note_709679901 |
Let me take a closer look at this. |
Figured it out. We need to include |
Description
When compiling on Ubuntu 21.10 after installing dependencies through apt, the project fails to compile
(I have attached the output of
make check
here: gtsamMakeCheckLog.txt)Steps to reproduce
Expected behavior
The library is expected to compile
Environment
I am using Ubuntu 21.10, gcc 11.2.0, cmake 3.18.4, boost 1.74, and the develop branch
Additional information
This issue has already been mentioned in this pull request, but the patch mentioned is no longer available
#391 (comment)
The text was updated successfully, but these errors were encountered: