Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique ID's #79

Open
haydar-metin opened this issue Dec 6, 2022 · 0 comments
Open

Unique ID's #79

haydar-metin opened this issue Dec 6, 2022 · 0 comments
Labels
bug Something isn't working client

Comments

@haydar-metin
Copy link
Collaborator

haydar-metin commented Dec 6, 2022

client side - svg

If a view has a def:

<defs>
    <filter id="dropShadow">
        <feDropShadow dx="1.5" dy="1.5" stdDeviation="0.5" style-flood-color="var(--uml-drop-shadow)" style-flood-opacity="0.5" />
    </filter>
</defs>

and the same view is used multiple times, then the id will be duplicated. Use a svg injector.

server side - gmodels

If we generate the ids dynamically (without using the .id() method in the builder) then there is a race condition:

  1. remove fixed .id(...) calls
  2. do changes in the client
  3. expect exception because the ids send to the server from the client are not the same that are expected from the server, because the client uses the old ones
@haydar-metin haydar-metin added bug Something isn't working client labels Dec 6, 2022
@haydar-metin haydar-metin changed the title Unique ID's on view definitions Unique ID's on svg def definitions Dec 7, 2022
@haydar-metin haydar-metin changed the title Unique ID's on svg def definitions Unique ID's Jan 3, 2023
@haydar-metin haydar-metin mentioned this issue Jan 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client
Projects
None yet
Development

No branches or pull requests

1 participant