Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Fix DUB issue 2012: Nested dub invocation behaves randomly #1323

Closed
Geod24 opened this issue Nov 4, 2020 · 4 comments
Closed
Assignees
Labels
C.General An issue which doesn't fit in the other categories (not blockchain related) type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense

Comments

@Geod24
Copy link
Collaborator

Geod24 commented Nov 4, 2020

Link: dlang/dub#2012

To do:

  • Make sure nested DUB invocations use the provided compiler by default. Add documentation to code.dlang.org (repository here: https://github.com/dlang/dub-registry) explaining the behavior.
  • Make sure the dub does not pick up the wrong dub.selections.json;
  • Do not propagate any DFLAGS unless passed explicitly ($DUB $DFLAGS);
@Geod24 Geod24 added type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense C.General An issue which doesn't fit in the other categories (not blockchain related) labels Nov 4, 2020
@Geod24 Geod24 added this to the 2. Validator milestone Nov 4, 2020
@omerfirmak
Copy link
Contributor

PR for Issue 1: dlang/dub#2047

@omerfirmak
Copy link
Contributor

PR#2: dlang/dub#2048

@omerfirmak
Copy link
Contributor

What is the problem with dub.selections.json exactly? When I test with projects, not single file operation, dub seems to use the local dub.selections.json of each project. Is there a specific case with the single file mode?

@Geod24
Copy link
Collaborator Author

Geod24 commented Dec 15, 2020

Oh the original message had a typo: I meant dub.settings.json (dub picks up the parent dub.settings.json). But this last bug does not actually block us, so this issue is done, thanks for your work!

@Geod24 Geod24 closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C.General An issue which doesn't fit in the other categories (not blockchain related) type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Development

No branches or pull requests

3 participants