Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed PR waiting for merge for 1 month now #56

Closed
formacube opened this issue Dec 24, 2021 · 3 comments
Closed

Reviewed PR waiting for merge for 1 month now #56

formacube opened this issue Dec 24, 2021 · 3 comments

Comments

@formacube
Copy link

Hi, could you proceed with the merge of #44 ?

One month has passed since linting preferences have been adapted according to your preferences

Thanks in advance

@formacube
Copy link
Author

I corrected 2 extra whitespaces which were " failing" !!!!!!!!!!!!!!! the tests (again ?)

I don't know exactly what is triggering the checking workflows.
I just have no idea what I'm doing, when I have to do what to get the things moving. I would appreciate a little bit of direction.
I have removed few whitespaces and added one linefeed since end of september ...

so I'm starting to be a bit fedup

@jedie
Copy link
Collaborator

jedie commented Jan 3, 2022

Just run make fix-code-style ... that should fix the tests. This can be manually checked with make lint

I reviewed #44 and will merge it, if tests are green.

@jedie jedie closed this as completed Jan 3, 2022
@formacube
Copy link
Author

Are you kidding me !!!!
you decide to kill everything after you made me wait for 6 months for you to validate the change of some spaces !!

My code is still plenty of patches since begining of september because you want me to change the formating of the code while it would take you less than 5 minutes to do it.

I have to wait for 6 month ...
and then you decide to kill everything.

Please you first merge my PR, so that I can have some code that works correctly.
Then when you have the time, you implement your new idea.

But in the meantime, at least, I can have a code that work.

@boxine boxine locked and limited conversation to collaborators Jan 7, 2022
@jedie jedie converted this issue into discussion #65 Jan 7, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants