Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR closed without merging first #59

Closed
formacube opened this issue Jan 7, 2022 · 3 comments
Closed

PR closed without merging first #59

formacube opened this issue Jan 7, 2022 · 3 comments

Comments

@formacube
Copy link

My PR has been closed without being merged.

My code is plenty of patches since begining of september because I'm waiting for you to validate the code.
You make me wait 6 months to change the formating of the code while it would take you less than 5 minutes to do it.

I have to wait for 6 month ...
and then you decide to kill everything because you have another idea ... that is not even yet implemented !

Please first merge my PR, so that I can have some code that works correctly and get rid of the patches.
Then when you have the time, there is no problem to implement your new idea.

But at least in the meantime, I can have a code that work, without monkey patch.
and also, it will be easy to test if your new idea is still functional for tasks that takes few days or few weeks to execute

@formacube
Copy link
Author

it does not really change anything for you.
For you there is no drawbacks merging this PR which is now ok and formated according to your standards.

But for me it changes a lot of things

@formacube
Copy link
Author

I couldn't react earlier as I was ill with covid.
I would appreciate if you stop closing all the issues and PRs before you get an answer. You can at least wait one or two weeks.

This is not very constructive, especially with all the efforts I put in it.

@jedie
Copy link
Collaborator

jedie commented Jan 7, 2022

I'm really sorry about how it all happend. It went very unhappily for you.
The whole thing is due to the fact that I had too little time for the project in the past. I hope that this will change.

I couldn't react earlier as I was ill with covid.

I hope you have gotten over it well!

Please first merge my PR, so that I can have some code that works correctly and get rid of the patches.

OK, i will do this.
But you added cumulate2parents in #44 to pervert spamming the database full, isn't it? But my refactor will remove this, because then the cache is used and it's useless, isn't it?
So in the end there is a release with cumulate2parents and a later release will deprecate this again.

Is this okay for you?

@boxine boxine locked and limited conversation to collaborators Jan 7, 2022
@jedie jedie converted this issue into discussion #60 Jan 7, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants