From 80d295cac4f0fd09089bbaf777bfad14062c14ce Mon Sep 17 00:00:00 2001 From: Pierre Bertet Date: Tue, 11 May 2021 15:02:28 +0100 Subject: [PATCH 1/4] README: add supported formats --- README.md | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/README.md b/README.md index b08df05..39cee76 100644 --- a/README.md +++ b/README.md @@ -60,6 +60,33 @@ function Nft() { } ``` +## Supported NFT formats + +Any standard NFT ([EIP 721](https://eips.ethereum.org/EIPS/eip-721) or [EIP 1155](https://eips.ethereum.org/EIPS/eip-1155)) is, in theory supported by useNft(). In practice, some adjustments are needed to support some NFT formats, either because their implementation doesn’t follow the specification or because some parts of the specifications can be interpreted in different ways. + +This table keeps track of the NFT minting services that have been tested with useNft() and the adaptations needed. + +| Minting service | Supported | Embedded adaptations | +| ---------------------------------------------------- | --------- | --------------------------------------------------------------------- | +| [AITO](https://www.thisisaito.xyz/) | Yes | | +| [Async Art](https://async.art/) | Yes | | +| [Clovers](https://clovers.network/) | Yes | | +| [CryptoKitties](https://www.cryptokitties.co/) | Yes | Non standard NFT, dedicated mechanism. | +| [CryptoPunks](https://www.larvalabs.com/cryptopunks) | Yes | Non standard NFT, dedicated mechanism. | +| [Cryptovoxels](https://www.cryptovoxels.com/) | Yes | | +| [Decentraland ](https://decentraland.org/) | Partially | Parcels require a fix (not implemented yet). Wearables are supported. | +| [Foundation](https://foundation.app/) | Yes | | +| [KnownOrigin](https://knownorigin.io/) | Yes | | +| [MakersPlace](https://makersplace.com/) | Yes | Fix the JSON format (`imageUrl` to `image`). | +| [MoonCats](https://mooncatrescue.com/) | Yes | Non standard NFT, dedicated mechanism. | +| [Nifty Gateway](https://niftygateway.com/) | Yes | Incorrect metadata URL. | +| [OpenSea](https://opensea.io/) | Yes | Incorrect metadata URL. | +| [Portion.io](https://app.portion.io/) | Yes | Non-standard JSON format. | +| [Rarible](https://rarible.com/) | Yes | | +| [SuperRare](https://superrare.co/) | Yes | | +| [Uniswap V3](https://uniswap.org/) | Yes | | +| [Zora](https://zora.co/) | Yes | | + ## API ### useNft(contract: string, tokenId: string): NftResult From a7596bc5cd0804aae180133342b91af6b8ed414e Mon Sep 17 00:00:00 2001 From: Pierre Bertet Date: Tue, 11 May 2021 15:04:25 +0100 Subject: [PATCH 2/4] Wording --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 39cee76..d993ff5 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Any standard NFT ([EIP 721](https://eips.ethereum.org/EIPS/eip-721) or [EIP 1155 This table keeps track of the NFT minting services that have been tested with useNft() and the adaptations needed. -| Minting service | Supported | Embedded adaptations | +| Minting service | Supported | Adaptations notes | | ---------------------------------------------------- | --------- | --------------------------------------------------------------------- | | [AITO](https://www.thisisaito.xyz/) | Yes | | | [Async Art](https://async.art/) | Yes | | @@ -77,7 +77,7 @@ This table keeps track of the NFT minting services that have been tested with us | [Decentraland ](https://decentraland.org/) | Partially | Parcels require a fix (not implemented yet). Wearables are supported. | | [Foundation](https://foundation.app/) | Yes | | | [KnownOrigin](https://knownorigin.io/) | Yes | | -| [MakersPlace](https://makersplace.com/) | Yes | Fix the JSON format (`imageUrl` to `image`). | +| [MakersPlace](https://makersplace.com/) | Yes | Incorrect JSON format (uses `imageUrl` instead of `image`). | | [MoonCats](https://mooncatrescue.com/) | Yes | Non standard NFT, dedicated mechanism. | | [Nifty Gateway](https://niftygateway.com/) | Yes | Incorrect metadata URL. | | [OpenSea](https://opensea.io/) | Yes | Incorrect metadata URL. | From d66d4c3855ccffcbeb8c32bc4609f1cb4da67799 Mon Sep 17 00:00:00 2001 From: Pierre Bertet Date: Tue, 11 May 2021 15:07:24 +0100 Subject: [PATCH 3/4] Wording --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d993ff5..795b841 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Any standard NFT ([EIP 721](https://eips.ethereum.org/EIPS/eip-721) or [EIP 1155 This table keeps track of the NFT minting services that have been tested with useNft() and the adaptations needed. -| Minting service | Supported | Adaptations notes | +| Service | Supported | Specific adaptations done by useNft() | | ---------------------------------------------------- | --------- | --------------------------------------------------------------------- | | [AITO](https://www.thisisaito.xyz/) | Yes | | | [Async Art](https://async.art/) | Yes | | From 0566844116cdb17b0f146ad9ae7bf9db0ba3df89 Mon Sep 17 00:00:00 2001 From: Pierre Bertet Date: Tue, 11 May 2021 15:08:56 +0100 Subject: [PATCH 4/4] Wording --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 795b841..32e2ad1 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Any standard NFT ([EIP 721](https://eips.ethereum.org/EIPS/eip-721) or [EIP 1155 This table keeps track of the NFT minting services that have been tested with useNft() and the adaptations needed. -| Service | Supported | Specific adaptations done by useNft() | +| NFT minting service | Supported | Specific adaptations done by useNft() | | ---------------------------------------------------- | --------- | --------------------------------------------------------------------- | | [AITO](https://www.thisisaito.xyz/) | Yes | | | [Async Art](https://async.art/) | Yes | |