Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a template is removed, documentation and other non-templated properties are gone #114

Open
barmac opened this issue Jul 30, 2024 · 3 comments · May be fixed by #120
Open

When a template is removed, documentation and other non-templated properties are gone #114

barmac opened this issue Jul 30, 2024 · 3 comments · May be fixed by #120
Assignees
@nikku @jarekdanielak
Labels
bug Something isn't working good first issue Good for newcomers ready Ready to be worked on spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented Jul 30, 2024

Describe the Bug

When I remove a template, the documentation is gone. The same applies to multi-instance configuration, and upcoming execution listeners.

Screen.Recording.2024-07-30.at.16.33.18.mov

Steps to Reproduce

  1. Add documentation
  2. Remove template
  3. now this happens

Expected Behavior

Properties are kept.

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@barmac barmac added the bug Something isn't working label Jul 30, 2024
@barmac barmac mentioned this issue Jul 30, 2024
Merged
@barmac barmac added backlog Queued in backlog good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Jul 31, 2024
@jarekdanielak jarekdanielak self-assigned this Aug 5, 2024
@jarekdanielak jarekdanielak added the in progress Currently worked on label Aug 21, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the backlog Queued in backlog label Aug 21, 2024
jarekdanielak added a commit that referenced this issue Aug 28, 2024
@jarekdanielak
fix: do not remove documentation and execution listeners when templat…
977003b 
…e is removed

Closes #114
@jarekdanielak jarekdanielak linked a pull request Aug 28, 2024 that will close this issue
Draft
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 28, 2024
@nikku
Copy link
Member

nikku commented Sep 18, 2024

@barmac I assume the rational for your expected behavior is: The fields you mentioned are not governed by the element template, hence they must not be "fiddled with" as the template is removed. Can you confirm?

@barmac
Copy link
Member Author

barmac commented Sep 18, 2024

Correct! The documentation, ELs, and multi-instance characteristics can be changed and live independently from the template, so they should not be removed with the template removal.
For example, if I send a notification to multiple employees, I should not need to reconfigure multi-instance when I change from Slack to email:

Screen.Recording.2024-09-18.at.12.21.19.mov

@barmac
Copy link
Member Author

barmac commented Sep 18, 2024

So it's a bit like we don't make a boundary event interrupting when a template is removed from a non-interrupting boundary event:

Screen.Recording.2024-09-18.at.12.23.45.mov

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 25, 2024
@nikku nikku added the ready Ready to be worked on label Oct 11, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Oct 11, 2024
@nikku nikku self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

@jarekdanielak jarekdanielak

Labels
bug Something isn't working good first issue Good for newcomers ready Ready to be worked on spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
3 participants
@nikku @jarekdanielak @barmac