Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning Text Annotation with a Sequence flow with name, creates unhandled error in event listener #2239

Open
par-shd opened this issue Sep 24, 2024 · 3 comments · May be fixed by #2241
Open

Aligning Text Annotation with a Sequence flow with name, creates unhandled error in event listener #2239

par-shd opened this issue Sep 24, 2024 · 3 comments · May be fixed by #2241
Assignees
@abdul99ahad
Labels
bug Something isn't working good first issue Good for newcomers in progress Currently worked on modeling

Comments

@par-shd
Copy link

par-shd commented Sep 24, 2024

Describe the Bug

An unhandled error in event listener happens when a Text Annotation is getting aligned with a Sequence flow that has a name
image

Steps to Reproduce

  1. Add a Sequence flow and add a name to it
  2. Create an annotation for the flow
  3. Now, try to align them in a vertical order (You need to release the mouse when the items are aligned)
image
  1. The following error happens:
unhandled error in event listener TypeError: Failed to execute 'setTranslate' on 'SVGTransform': The provided float value is non-finite.
    at ro (SvgTransformUtil.js:35:13)
    at io.update (GraphicsFactory.js:277:5)
    at ChangeSupport.js:61:21
    at EventBus.js:614:13
    at Zr._invokeListener (EventBus.js:457:19)
    at Zr._invokeListeners (EventBus.js:431:24)
    at Zr.fire (EventBus.js:379:24)
    at ChangeSupport.js:46:14
    at EventBus.js:614:13
    at Zr._invokeListener (EventBus.js:457:19)
    at Zr._invokeListeners (EventBus.js:431:24)
    at Zr.fire (EventBus.js:379:24)
    at ChangeSupport.js:54:16
    at Array.forEach (<anonymous>)
    at ChangeSupport.js:53:14
    at EventBus.js:614:13
    at Zr._invokeListener (EventBus.js:457:19)
    at Zr._invokeListeners (EventBus.js:431:24)
    at Zr.fire (EventBus.js:379:24)
    at Kv._popAction (CommandStack.js:503:20)
    at Kv.execute (CommandStack.js:187:8)
    at Kg.moveElements (Modeling.js:243:22)
    at Move.js:177:14
    at EventBus.js:614:13
    at Zr._invokeListener (EventBus.js:457:19)
    at Zr._invokeListeners (EventBus.js:431:24)
    at Zr.fire (EventBus.js:379:24)
    at s (Dragging.js:187:21)
    at l (Dragging.js:283:21)
    at HTMLDocument.u (Dragging.js:332:5)
    at HTMLDocument.o (helpers.ts:98:17)

Expected Behavior

No errors

Environment

  • Browser: Chrome Version 128
@par-shd par-shd added the bug Something isn't working label Sep 24, 2024
@nikku nikku added modeling ready Ready to be worked on labels Sep 24, 2024
@nikku
Copy link
Member

nikku commented Sep 24, 2024

Thanks for the report, I can reproduce this issue.

@barmac barmac added the good first issue Good for newcomers label Sep 24, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 30, 2024
abdul99ahad added a commit that referenced this issue Sep 30, 2024
@abdul99ahad
fix: flow text alignment issue when placed text annotation
4cb0fad 
Closes #2239
@abdul99ahad abdul99ahad linked a pull request Sep 30, 2024 that will close this issue
Open
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Sep 30, 2024
abdul99ahad added a commit that referenced this issue Oct 14, 2024
@abdul99ahad
fix: flow text alignment issue when placed text annotation
53ed469 
Closes #2239
abdul99ahad added a commit that referenced this issue Oct 14, 2024
@abdul99ahad
fix: flow text alignment issue when placed text annotation
56fda2e 
Closes #2239
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 14, 2024
@abdul99ahad
Copy link
Contributor

Hi, we have two potential approaches to address the issue where a text annotation is placed above a flow element label:

Ignore the connection label: This approach avoids breaking anything but may raise some UX concerns.

Gracefully adjust the connection label: This works well for simple connections, but it introduces inconsistencies when dealing with more complex cases.

Ignoring the connection label is simpler but may impact the user experience, while handling the adjustment offers better UX in basic scenarios but struggles with more complex connections.

abdul99ahad added a commit that referenced this issue Oct 16, 2024
@abdul99ahad
fix: flow text alignment issue when placed text annotation
87b4f7c 
Closes #2239
@abdul99ahad
Copy link
Contributor

Handling label positions for complex connections involves a more intricate process. At the moment, we’re opting to ignore the connection label when one is present, as we currently don’t support label adjustment for connections.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working good first issue Good for newcomers in progress Currently worked on modeling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2239 text annotation alignment bpmn-io/bpmn-js
4 participants
@nikku @barmac @abdul99ahad @par-shd