Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BKM as literal expression #826

Closed
4 tasks done
barmac opened this issue Feb 5, 2024 · 4 comments · Fixed by #852
Closed
4 tasks done

Implement BKM as literal expression #826

barmac opened this issue Feb 5, 2024 · 4 comments · Fixed by #852
Assignees

Comments

@barmac
Copy link
Member

barmac commented Feb 5, 2024

What should we do?

  • I can morph BKM to literal expression
  • I can open BKM
  • I can write BKM body as literal expression
  • I can specify parameters of BKM

Why should we do it?

Part of https://github.com/camunda/product-hub/issues/1858

Related to #704

@barmac barmac added the ready Ready to be worked on label Feb 5, 2024
@barmac barmac self-assigned this Feb 5, 2024
@barmac
Copy link
Member Author

barmac commented Feb 5, 2024

@lmbateman We will need to discuss how we want the user to specify the parameters.

@barmac
Copy link
Member Author

barmac commented Feb 28, 2024

Today, @nikku and I talked about this topic.

We concluded that it makes sense to have a new project within dmn-js family dedicated for all boxed expressions with nesting in mind. Initially, this will support BKM as literal expression. In the future, we can implement other boxed expressions as well as migrate the existing ones (decision table, literal expression for decision).

There's also an idea to upgrade the rendering engine to migrate off Inferno 5, but it's a separate story which can be implemented after the BKM as literal expression is done.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 28, 2024
@barmac
Copy link
Member Author

barmac commented Mar 7, 2024

Current state of this is available at https://boxed-expression.netlify.app/

There's still much to do regarding style, but at least the core features work.

@barmac
Copy link
Member Author

barmac commented Mar 18, 2024

@lmbateman and I discussed today the UI part and agreed on the following:

  1. The formal parameters will be displayed more like in the specification first, and open the modeling view once edit button is clicked ("pencil").
  2. The expression will be displayed without box.

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant