Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] moving command line error to infobar and fixing windows port range issues #442

Open
core-ai-bot opened this issue Aug 17, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by jha-g
Wednesday Nov 20, 2019 at 13:46 GMT
Originally opened as adobe#673


Windows was allowing Brackets to open a remote debugging port on any port in the range [1,65534], which was troubling.
So, have started setting settings.remote_debugging_port=65535 in case of ports outside the interval [1024,65534].
Which stops Brackets from opening a reserved port and this stops error thrown in bind() on Linux and Mac.


jha-g included the following code: https://github.com/adobe/brackets-shell/pull/673/commits

@core-ai-bot
Copy link
Member Author

Comment by jha-g
Thursday Nov 21, 2019 at 10:00 GMT


Reference to setting remote-debugging-port to 65535 to disable remote debugging:
CEF 2785
CEF 2623
CEF 2704

And CEF has fixed this issue of not validating reserved ports, interval [0,1023], in later branches:
CEF 3202

@core-ai-bot
Copy link
Member Author

Comment by jha-g
Thursday Nov 21, 2019 at 10:16 GMT


@shubhsnov renamed the error string variable, as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant