-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Collapsing is broken #10515
Comments
Comment by ghost I get this all the time, very frustrating. |
Comment by ficristo I cannot reproduce with this small javascript snippet: function foo() {
if (false) {
return;
}
} Can you look at |
Comment by ghost If it was one specific example that would be one thing, but its everywhere all the time. Its screwed up more often than it works. I downgraded to Brackets 1.5 and it works perfectly again. |
Comment by ghost I'm not sure how to reproduce exactly, but it happens all the time after maybe a couple of collapsing/ expanding actions. This is a screenshot from the devtools - |
Comment by ghost Is this issue easily fixable / will it be fixed soon? It's making the ide unusable. I went as far as to install an extension that was supposed to handle collapsing but brackets threw an error saying that extension was usable. |
Comment by ghost Yes it makes this version of Brackets completely unusable. I downgraded to 1.5 and it works great, there are a few extensions I cant use but all the ones I want I can use so my suggestion would be to downgrade until this is fixed. |
Comment by ghost So Brackets 1.7 came out today and I was all excited thinking I could start using the latest version of brackets again so I could get the latest plugins... NOPE you still have not fixed this issue, it's still happening. Your IDE is still completely unuseable because your collapsing is broken. |
Comment by ficristo The issue is clear, not how can we reproduce. |
Comment by ghost I can't reproduce it in the demo. It normally does not start happened until I've been using brackets for a 1/2 hour+, but with a long enough time using brackets its happens EVERY time. The log shows no errors. I'm just going to switch to another IDE. |
Comment by thehogfather
|
Comment by ghost I am using Windows 10. I have experienced this error with Brackets 1.6 and 1.7. I may have more than one file open with Brackets but only ever 1 instance of Brackets open at once. That particular file has about 300 lines of code. Another thing I just thought of is that I always work off a network drive. The file never sits on my local machine but rather a server so that I can access it from multiple workstations, and yes this error occurs on multiple workstations (all windows 10). Currently I have uninstalled Brackets 1.6 and 1.7 because this problem is so bad and I use Brackets 1.5, which works perfectly always. So what changed between Brackets 1.5 and 1.6? Are they using the same version of CodeMirror or did Brackets update it's version of CodeMirror between those builds? |
Comment by thehogfather
The issue has to do with the caching and syncing of the folded lines and that significantly changed across versions. If you are able to test this, that would be great - otherwise I might reconsider resurrecting the extension version of this so that I can make more frequent bug fixes. |
Comment by ghost I'm just going to stick with Brackets 1.5 for now and would like to some kind of notification when this issue is fixed so that I can upgrade. |
Comment by designcise I was able to reproduce this by:
I have witnessed this problem on other occasions as well, but like others have pointed out, haven't been able to reproduce it. |
Comment by alignsoft I'm seeing this issue as well with Brackets 1.7 on a Mac running OS X 10.11.5 Folding works fine for a while, but after some time the triangles stop responding, usually after unfolding a function to review, then the triangle indicates it's collapsed again even though the code is still visible, and after that I have to quit and relaunch Brackets to get folding working again. Project is 40 files ±, ranging anywhere from a few dozen to 1,000 lines of code. |
Comment by thehogfather In the end the issue is quite easy to reproduce. All one has to do is the following:
Note that I have done the best I can to address this issue by submitting a PR #12521. It is a tiny change and should be easy to review. Happy to answer any questions about the context. I cannot do more than that. Someone with write permissions on the repo needs to review and decide whether or not to merge this. I am still investigating whether this bug goes all the way back to the CodeMirror api. cc |
Comment by abose tagging |
Comment by derrickb Can confirm I'm on Windows 10 x64, Brackets 1.7 |
Comment by alignsoft Any chance this can get merged into the project? Is there a 1.7.1 update in the wings? |
Comment by nethip
https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets |
Comment by ghost So has the bug's cause been identified and fixed? Is it fixed in source? If not then there is no point in running from Source yet. |
Comment by ficristo Should be fixed in 1.8 by adobe/brackets#12521 |
Comment by ghost Thank You, I will give it a shot when I get the chance |
Issue by ghost
Friday Feb 19, 2016 at 13:42 GMT
Originally opened as adobe/brackets#12232
Sometimes when I collapse and uncollapse code that has collapsible code within it (like a function with an if statement within it) everything gets all screwed up and the collapse arrows point the wrong direction and the collapsing just stops working all together.
The text was updated successfully, but these errors were encountered: