Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] switch project performance improvements #1182

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] switch project performance improvements #1182

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Friday Jun 29, 2012 at 21:27 GMT
Originally opened as adobe/brackets#1197


Changes:

  • Do not check disk for file existence when opening files for a project, just add them to the working set. Handle case where a working set file no longer exists.
  • Fix ChangedDocumentTracker so it doesn't read each file from disk as they are added to working set. Start/stop tracking documents when created/deleted.
  • Handle adding/removing multiple working set files at a time to minimize how many times re-layout is done for working set and project tree once (i.e. not for each file). Note that re-layout is triggered when calculating whether to draw shadow, selection rectangle, and selection triangle.
  • Also implement these improvements for multiple file open

redmunds included the following code: https://github.com/adobe/brackets/pull/1197/commits

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Monday Jul 09, 2012 at 22:16 GMT


Initial review complete.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Jul 10, 2012 at 00:31 GMT


Finished with updates for initial code review.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday Jul 10, 2012 at 00:58 GMT


Looks good, and definitely speeds up project loading! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant