[CLOSED] Auto Update Error Handlng Fix

[core-ai-bot]

Issue by niteskum
Monday Jun 11, 2018 at 13:30 GMT
Originally opened as adobe/brackets#14412

---

---

niteskum included the following code: https://github.com/adobe/brackets/pull/14412/commits

[core-ai-bot]

Comment by niteskum
Monday Jun 11, 2018 at 13:30 GMT

---

ping@nethip@vickramdhawal for review

[core-ai-bot]

Comment by nitheshgangadharsalian
Tuesday Jun 12, 2018 at 15:37 GMT

---

Bug: adobe/brackets#14411

[core-ai-bot]

Comment by nethip
Thursday Jun 21, 2018 at 10:13 GMT

---

@niteskum Could you provide description here as to how the bugs has been fixed? And also possible reasons as to how one can run into this error?

[core-ai-bot]

Comment by niteskum
Thursday Jun 21, 2018 at 16:05 GMT

---

@nethip In setupAutoUpdate() function initNode() and initState() function were called one after another. So there were no synchronization between setUpdateInProgressState() and CheckUpdateStatus()
InitNode Function notifies Brackets to reset inProgress Flag when Bracket is launched. and initState() function used to call checkUpdateFunction() which cleans up Update Temp Folder If Update was initiated in prev session. sometime UpdateTemp were being cleaned up before setting up the flags. and Exception were thrown in setUpdateInProgress() function because there was no File to write.

Changes in this PR:
Renamed the function "setAutoUpdateInProgressFlag" to "nodeDomainInitialized". and from initNode Function Node Notifies to Brackets to execute "nodeDomainInitialized" function and pass a parameter "reset" which is true If Brackets is launched. and false If New Brackets Window is opened.
and in nodeDomainInitialized function , initState() Function is called . and resetting of "InProgress"Flag and checkUpdateStatus() are executed in sequence.
so this makes sure There is No RaceCondtion between resetting the flag and cleaning up the temp folder.