Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Reinitiate tooling service on Node process crash #12006

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

[CLOSED] Reinitiate tooling service on Node process crash #12006

core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by shubhsnov
Wednesday Apr 24, 2019 at 18:43 GMT
Originally opened as adobe/brackets#14724


All tooling extensions dependent on LanguageClient module in Brackets must only initiate tooling service post the initialization of the module on Node side. On cold launch, we were waiting for the initialization and only then loading the respective client domain. However, when the node process crashes due to any issue, both the language server, as well as the initialized state in the node process are lost. The client then becomes useless.

Solution: Broadcasting an event in the Brackets context to inform the client to reinitiate tooling service once the node process is back up and initialized with LanguageClient module information.

Adding reference handling of the event in the PhpTooling extension.

ping@narayani28@swmitra@niteskum for review.


shubhsnov included the following code: https://github.com/adobe/brackets/pull/14724/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant