Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Selection jiggles while resizing window horizontally #1264

Open
core-ai-bot opened this issue Aug 29, 2021 · 8 comments
Open

[CLOSED] Selection jiggles while resizing window horizontally #1264

core-ai-bot opened this issue Aug 29, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Thursday Jul 19, 2012 at 15:13 GMT
Originally opened as adobe/brackets#1283


Recipe:

  1. On any page, find/create a line of text with > 60 chars
  2. Select roughly the middle 1/3 of the line of text
  3. Change the width of brackets app

Results:
The painting of the selection highlighting briefly changes with the width of the window (seems to be a percentage of viewport width). It quickly snaps back to the correct size, but there is enough delay to make it very noticeable.

Expected:
Selection highlighting does not change with editor window width

This seems to be caused by recent CodeMirror changes.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Jul 19, 2012 at 16:41 GMT


Definitely a regression from the last CodeMirror merge. Probably same cause as #1267. Marijn has already pushed up a fix for that, so I'll test whether it covers this case too.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Jul 19, 2012 at 16:51 GMT


Confirmed this is now fixed in CodeMirror upstream -- next sprint's CM merge will give us a fix

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Tuesday Jul 24, 2012 at 17:48 GMT


Reviewed thats opened for Sprint 12. Waiting to get the fix in CM.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Aug 02, 2012 at 17:25 GMT


The CodeMirror merge has been deferred to Sprint 13 due to some recent instability in the CM scrolling code. Pushing this bug out till then.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Aug 21, 2012 at 21:17 GMT


This seems much harder to reproduce in brackets-shell, but it's definitely still there (noticeable especially on my older Mac).

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Aug 23, 2012 at 18:38 GMT


Turns out the fix in CodeMirror (which we've merged) doesn't fully fix this case, though it does reduce how often it happens. I've filed codemirror/codemirror5#745 on this, so we can continue to track it. Removing sprint 13.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Thursday Sep 20, 2012 at 22:07 GMT


This is fixed in CodeMirror v3 branch. See codemirror/codemirror5@314e7ea

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Saturday Jan 26, 2013 at 00:42 GMT


Confirmed that this is fixed in cmv3 branch. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant