[CLOSED] Fix #2076: Two indistinguishable events for different cases of working set reordering

[core-ai-bot]

Issue by TomMalbran
Saturday Mar 09, 2013 at 09:00 GMT
Originally opened as adobe/brackets#3080

---

I went back to the working set sort and managed to merge both events workingSetReoder and workingSetSort into one workingSetSort and leaving almost the same functionality as before fixing #2076.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/3080/commits

[core-ai-bot]

Comment by TomMalbran
Tuesday Apr 16, 2013 at 23:28 GMT

---

I added a few fixes here so that #3440 is still fixed after this request is merged.

[core-ai-bot]

Comment by njx
Friday Jun 07, 2013 at 17:32 GMT

---

Reassigned to@redmunds

[core-ai-bot]

Comment by redmunds
Tuesday Jun 11, 2013 at 23:11 GMT

---

@TomMalbran Sorry it's taken so long to get to this one. I started to review it, but there's a merge conflict. Can you merge the latest code? Thanks.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jun 12, 2013 at 00:40 GMT

---

Sure, I'll fix the merge issue. Thanks for looking into this.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jun 12, 2013 at 01:05 GMT

---

@redmunds Merged with master and fixed the conflict issue.

[core-ai-bot]

Comment by redmunds
Wednesday Jun 12, 2013 at 03:54 GMT

---

Done with initial review.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jun 12, 2013 at 07:33 GMT

---

@redmunds Fixed the comment issues. Check on my replies about the event to see what we can do next. Thanks.

[core-ai-bot]

Comment by redmunds
Wednesday Jun 12, 2013 at 15:47 GMT

---

Done with second review.

[core-ai-bot]

Comment by TomMalbran
Thursday Jun 13, 2013 at 22:19 GMT

---

I updated a bit the comment on the workingSetSort event and added a new workingSetDisableAutoSorting called every time 2 files are swapped when dragging and dropping them. This added a new event, but works better than before by not unnecessarily redrawing the working set after a drag/drop action. There might be a smarter way of figuring out when doing an automatic sort if it was previously resorted via a drag/drop action and avoid having the new event, but it is easier to do it like this.

[core-ai-bot]

Comment by redmunds
Friday Jun 14, 2013 at 22:26 GMT

---

Thanks! Looks good. Merging.

[core-ai-bot]

Comment by peterflynn
Monday Jul 08, 2013 at 23:14 GMT

---

Note: I've reopened #2076 for more discussion since this doesn't appear to address the main confusion/pitfall I was concerned about (and in some sense the event name change may have made it worse).