[CLOSED] Validate and install extensions (final)

[core-ai-bot]

Issue by njx
Monday Mar 18, 2013 at 23:47 GMT
Originally opened as adobe/brackets#3158

---

This supersedes #3137, and should contain just the changes for the installer pull request separate from the node modules in #3156.

---

njx included the following code: https://github.com/adobe/brackets/pull/3158/commits

[core-ai-bot]

Comment by dangoor
Tuesday Mar 19, 2013 at 01:35 GMT

---

Just cc'ing myself at this point.

[core-ai-bot]

Comment by njx
Tuesday Mar 19, 2013 at 02:38 GMT

---

@dangoor@peterflynn -- re-review (for non-UI parts) complete. I'm not going to merge right now, but will be online later tonight--Peter, if you push some fixes up before I get back online, that's cool, otherwise I'll likely go ahead and merge then; there aren't really any major showstoppers that I see, though there are a few things we should definitely address before DoD.

@dangoor -- don't remember where I mentioned this before, but the main changes for the UI stuff (outside of InstallExtensionDialog) were:

1. refactor out the CSS for busy spinner so we use common code everywhere
2. slightly refactor the HTML/CSS for the Project Settings dialog so I can use the same structure in the Install Extension dialog
3. fix the button positioning in a couple of dialogs that had Cancel on the left side of the dialog instead of the right (it should be on the right, but to the left of the OK button)
4. add an autoDismiss flag to showModalDialogUsingTemplate() that allows the caller to manually handle button clicks when set to false (instead of the dialog automatically dismissing itself)

[core-ai-bot]

Comment by pthiess
Tuesday Mar 19, 2013 at 02:45 GMT

---

@njx@dangoor@peterflynn Thank you guys for your hard work on this exciting pull into Brackets. Very cool!

[core-ai-bot]

Comment by njx
Tuesday Mar 19, 2013 at 05:52 GMT

---

Went ahead and merged this.@dangoor -- if you end up having any comments on the UI stuff, feel free to add the comments to this pull request and I can look at them here later.

[core-ai-bot]

Comment by dangoor
Tuesday Mar 19, 2013 at 14:30 GMT

---

I've finished reviewing the UI code.