Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] UI fixes for installer dialog #2983

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] UI fixes for installer dialog #2983

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Tuesday Mar 19, 2013 at 23:02 GMT
Originally opened as adobe/brackets#3173

Responses to code review comments for the UI from #3158. Note that all the changes in the unit test file (below the new code for managing the test window) are just a reindentation.

njx included the following code: https://github.com/adobe/brackets/pull/3173/commits
@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Mar 19, 2013 at 23:02 GMT

To@dangoor

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Wednesday Mar 20, 2013 at 13:02 GMT

woah. Those tests are much faster!

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Wednesday Mar 20, 2013 at 13:03 GMT

this is ready to merge. Does it need to wait for@peterflynn's cancellation changes?

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Mar 20, 2013 at 16:20 GMT

No, I don't think these will conflict. Pushing the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot