Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Add placeholder menu when running native menu unit tests. #3581

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] Add placeholder menu when running native menu unit tests. #3581

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by gruehle
Tuesday May 14, 2013 at 19:37 GMT
Originally opened as adobe/brackets#3825

Fix for #2677

Add a placeholder menu at the beginning of the Native Menu unit tests and remove it at the end.

This fixes the annoying flicker on Windows when running all of the tests.

gruehle included the following code: https://github.com/adobe/brackets/pull/3825/commits
@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Jun 06, 2013 at 02:47 GMT

I'll review this request.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Jun 06, 2013 at 02:54 GMT

This looks great. The jiggling is gone and all the test still pass. I just commented on 2 nits and an important question about the waitsFor usage.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Thursday Jun 06, 2013 at 03:29 GMT

@TomMalbran thanks for the review! I've addressed all of the comments and pushed the changes.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Jun 06, 2013 at 03:45 GMT

Everything is still working great. Thanks for the fixes. Merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot