Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Rename 'Show in OS' to 'Show in Finder' for OS X #6310

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] Rename 'Show in OS' to 'Show in Finder' for OS X #6310

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by hipwelljo
Saturday Feb 22, 2014 at 03:31 GMT
Originally opened as adobe/brackets#6970


When right-clicking a file in the sidebar, one of the options is "Show in OS." If you can, for OS X rename that option to "Show in Finder." Then it'll be much more recognizable and easy to spot out that option, since that's what other OS X apps (iTunes) use. It's very unclear what 'OS' is.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Feb 22, 2014 at 12:03 GMT


Good idea, would be Explorer on Windows. See adobe/brackets#2128 (comment)

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Sunday Feb 23, 2014 at 07:28 GMT


I could swear we had a starter bug for this already, but I can't seem to find it so... marking this 'starter bug.'

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Feb 23, 2014 at 11:51 GMT


I'd like to take this.
But I don't know what strings I should use.

Linux should stay Show in OS, right?
Are Finder and Explorer the same in every language? (specifically some with other letters like Russian, Chinese or Persian)

Should we use sth like this:

"CMD_SHOW_IN_OS": "Show in OS", // Linux only
"CMD_SHOW_IN_OS_FILEMANAGER": "Show in {0}" // {0} is Explorer/Finder

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Feb 23, 2014 at 19:51 GMT


I think it might be a lot easier to create 3 separate strings, one per OS, since it would be easier to translate.

In Spanish we can translate Explorer to Explorador, making it Mostrar en el Explorador. But not sure if we translate Finder, so if we don't, it should be Mostrar en Finder. So it might not be just a string replacement.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Feb 26, 2014 at 21:34 GMT


@hipwelljo Closing, since #6982 implements the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant