Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a version number for the next release #28

Closed
ScanuNicco opened this issue Oct 5, 2021 · 8 comments · Fixed by #35
Closed

Choose a version number for the next release #28

ScanuNicco opened this issue Oct 5, 2021 · 8 comments · Fixed by #35

Comments

@ScanuNicco
Copy link
Contributor

The master branch is current on version 1.15, however it doesn't seem like there have been enough changes to justify calling it 1.15. Either we should call it 1.14.3 or, if we want the version numbers to reflect the transition from adobe to the community, we should call it 2.0.0.

@abose
Copy link
Member

abose commented Oct 6, 2021

+1 for 2.0.0 . This would be a major release if we are incorporating electron shell.

@kimdorris
Copy link

As this is a wholly separate project from the Adobe product, albeit a continuation, I agree the version should be 2.0.0 to distinguish it from the Adobe product, IMHO.

@kimdorris
Copy link

@abose said:

+1 for 2.0.0 . This would be a major release if we are incorporating electron shell.

@kimdorris replied:
+1 for the +1! 🙌

@ScanuNicco
Copy link
Contributor Author

A release with electron should definitely be 2.0.0, but as migrating to electron will take a while I was thinking that we would make a minor release to fix the registry before that.

@abose
Copy link
Member

abose commented Oct 8, 2021

Agree with @ScanuNicco on this. It looks like the electron port will take a while with quadre-code backing up from merging to brackets.

if we want the version numbers to reflect the transition from adobe to the community, we should call it 2.0.0.
  • Agree with @ScanuNicco on this even without an electron port.

With a minor build, we can set up the release engineering pipeline to build and publish installers and fix our immediate user pain points of basic functionality breaks.

@ScanuNicco
Copy link
Contributor Author

It looks like we're decided on 2.0.0 then. Will changing version and apiVersion in src/config.json and in package.json update the version number or are there other files that need to be changed?

@abose
Copy link
Member

abose commented Oct 13, 2021

@ScanuNicco These would be the changes:

adobe/brackets#14733
adobe/brackets-shell#667

@ScanuNicco
Copy link
Contributor Author

Ok I can submit a PR to change the version number to 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants