-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Multiplicity{M}
type
#199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainandforce
force-pushed
the
features/spin-range
branch
3 times, most recently
from
November 16, 2023 17:31
45bf593
to
3457e77
Compare
I decided to rename the type to |
brainandforce
force-pushed
the
features/spin-range
branch
from
November 16, 2023 21:25
0567037
to
dea2a4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 59.77% 58.69% -1.09%
==========================================
Files 20 21 +1
Lines 1432 1346 -86
==========================================
- Hits 856 790 -66
+ Misses 576 556 -20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type should facilitate indexing of some new data types by spin state.
SpinRange{M}
has a single type parameter, the multiplicityM
, which is anInt
, and it behaves likeUnitRange(-(M-1)//2, (M-1)//2)
, where all elements are valid angular momenta for that multiplicity.I am willing to go back and rename this type to
Multiplicity
or something else, because even thoughSpinRange
is anAbstractUnitRange
, the type parameterM
is the spin multiplicity.