Support connecting through a socks proxy #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some weird reason, code coverage isn't being captured, however I can tell this change actually makes a difference. When Redshift is in a VPC and not publicly accessible, and
|
winglot
approved these changes
Aug 20, 2021
Tenzer
added a commit
to Tenzer/terraform-provider-postgresql
that referenced
this pull request
Mar 30, 2022
This copies the implentation from the Redshift provider: brainly/terraform-provider-redshift#19. It allows users to proxy the requests to the database server through a SOCKS proxy, in case the database server cannot be reached directly.
Tenzer
added a commit
to Tenzer/terraform-provider-postgresql
that referenced
this pull request
Apr 21, 2022
This copies the implentation from the Redshift provider: brainly/terraform-provider-redshift#19. It allows users to proxy the requests to the database server through a SOCKS proxy, in case the database server cannot be reached directly.
cyrilgdn
added a commit
to cyrilgdn/terraform-provider-postgresql
that referenced
this pull request
May 4, 2022
* Add SOCKS proxy support This copies the implentation from the Redshift provider: brainly/terraform-provider-redshift#19. It allows users to proxy the requests to the database server through a SOCKS proxy, in case the database server cannot be reached directly. * Mention SOCKS5 proxy support to usage documentation As part of this I found out the format of the values in the environment variables isn't standardized, so there only place we potentially could link to about the format of the values would be the source code for `golang.org/x/net/proxy`. I thought that was a bit much, so I've instead included a simple example instead. Co-authored-by: Cyril Gaudin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers a custom driver name for pq, per lib/pq#470 (comment), and uses it to override the default dialer with one that can transparently handle socks proxy configuration through environment variables.
The environment variable is named
ALL_PROXY(all_proxyalso works) and has the formatsocks5[h]://[<socks-user>:<socks-password>@]<socks-host>[:<socks-port>]There is also support for a
NO_PROXY/no_proxyenvironment variable which lists hostnames, IP addresses, CIDR blocks, and wildcard domain names which should not go through the proxy.