Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region support when calling GetClusterCredentials #60

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

bendrucker
Copy link
Contributor

When calling GetClusterCredentials, users must supply the region where the Redshift cluster is located. Currently, there is no explicit provider configuration field for this input. As noted in #58 (comment), you can use AWS_REGION to set this.

I checked the AWS provider and mirrored its simple field implementation, with no validation:

https://github.com/hashicorp/terraform-provider-aws/blob/19469514cc16736d80ab976aa3178d5aaedbeba8/internal/provider/provider.go#L292-L297

@bendrucker
Copy link
Contributor Author

Hi @winglot @pawelaugustyn, wondering if you're planning to actively maintain this provider. It's been a big help for @TakeScoop and I'm happy to continue submitting improvements if it's of interest. Otherwise, happy to fork if you're not looking for outside contributions.

@mtesch-um
Copy link
Contributor

I'll second that - it's been a huge help for us too - we're more than happy to help out with maintenance if there's anything we can do.

@winglot
Copy link
Member

winglot commented Apr 14, 2022

@bendrucker Sorry for the delays. I had a busy couple of weeks. I have the review and merge processes on my agenda for the beginning of next week.

@bendrucker
Copy link
Contributor Author

Quite alright, thanks for the update!

@winglot winglot merged commit 6c2781e into brainly:master Apr 19, 2022
@winglot winglot added the enhancement New feature or request label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants