Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readSchemaGrants and readTableGrants for groups #76

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix readSchemaGrants and readTableGrants for groups #76

merged 1 commit into from
Aug 4, 2022

Conversation

olivermeyer
Copy link
Contributor

@olivermeyer olivermeyer commented Aug 4, 2022 •
edited
Loading

This PR fixes the readSchemaGrants and readTableGrants functions. They currently don't work correctly if two groups start with the same name and have different permissions: in our case, we have a data group and a data_eng legacy group and the queries were returning the privileges for the data_eng group, even when gr.groname == data.

@olivermeyer
Copy link
Contributor Author

@winglot please can you take a look at this?

@winglot winglot merged commit c8ca177 into brainly:master Aug 4, 2022
@olivermeyer olivermeyer deleted the fix-read-table-and-schema-grants branch August 4, 2022 10:56
@winglot winglot added the bug Something isn't working label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglot winglot winglot approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermeyer @winglot