Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to upgrade version of Node #78

Open
vpress-admin opened this issue Oct 12, 2021 · 1 comment
Open

How to upgrade version of Node #78

vpress-admin opened this issue Oct 12, 2021 · 1 comment

Comments

@vpress-admin
Copy link

I understand that this project is no longer maintained and is pretty much dead. But the Electron like APIs and vastly reduced bundle size and support for vibrancy are a must for me. Only thing holding me back is the Node 12.x. I've built the project but can't work out how to upgrade Node. Anyone able to help on this..?

@ci010
Copy link

ci010 commented Feb 22, 2022

Basically, you need to change the node version cmake file here https://github.com/patr0nus/DeskGap/blob/master/node/CMakeLists.txt#L48.

But that won't work, as current master is using nod at https://github.com/patr0nus/DeskGap/blob/master/node/CMakeLists.txt#L49, the nod and DeskGap is not up-to-date.
While you set the version to like node 17, it will failed as libnode release format changed.

Basically, the DeskGap depends on nod to bootstrap nodejs, and nod is using libnode as static library to link node.
Though, you only need to fork libnode to make it work (or you can use my fork).

For detail, see my fork of libnode, and my fork of DeskGap. The recent commits should explain how this work.
You need to focus on the cmake file changes in node/CMakeLists.txt and bootstraping code in node/src/main.cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants