Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace context.TODO() calls with proper context #96

Open
paulfantom opened this issue Oct 19, 2020 · 2 comments
Open

Replace context.TODO() calls with proper context #96

paulfantom opened this issue Oct 19, 2020 · 2 comments
Labels
enhancement help wanted

Comments

@paulfantom
Copy link
Collaborator

New k8s client-go forces passing context in function calls. It would be good to pass proper context instead of TODO.

This should be considered as a follow-up to #95
@brancz brancz mentioned this issue Oct 20, 2020
Merged
@bilalcaliskan
Copy link

@paulfantom hello, i would like to contribute to that project! can you assign that issue to me please?

@paulfantom
Copy link
Collaborator Author

@bilalcaliskan go for it :)

@bilalcaliskan bilalcaliskan mentioned this issue Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use proper context instead of context.TODO()
2 participants
@paulfantom @bilalcaliskan