-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPUS as audio container #37
Comments
I see that the FFmpeg build used by the application does support Opus. Are you familiar with what codecs are supported in that container? Adding support is easy enough, just an entry to the MediaContainer enum and any audio codecs to the AudioCodec enum, along with looking up the proper ffmpeg arguments. If someone were willing to track that information down and test it I could help review the pull request. |
Well as far as I know MKV, WEBM and MP4 can be used as a container. Wikipedia shows MPEG-TS addition to my mentions. |
.opus and .ogg as well |
The version and build of FFmpeg which is being used does support the opus codec, both in an opus audio container and in the MKV video container. This support is now exposed to the UI. FFmpeg does have experimental support for mp4, but this is not being exposed as I'm not sure how well "experimental support" works. Playing with it, I did observe that opus supports only some sample frequencies (list on this page), but presently more options than are valid are displayed. In the future the list of valid options should be shown instead of a broad list. If there is something that I missed, let me know. |
No description provided.
The text was updated successfully, but these errors were encountered: