Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Expand estimated pending rewards to three decimal places #10028

Closed
jsecretan opened this issue Jun 1, 2020 · 2 comments · Fixed by brave/brave-core#5858
Closed

[Android] Expand estimated pending rewards to three decimal places #10028

jsecretan opened this issue Jun 1, 2020 · 2 comments · Fixed by brave/brave-core#5858
Assignees
@tmancey
Labels
ARM Android ARM related issues enhancement feature/ads OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@jsecretan
Copy link

jsecretan commented Jun 1, 2020 •
edited by tmancey
Loading

Description

Currently the estimated pending rewards display on the brave://rewards page, and the ad grant claimed amounts round to one decimal place. They should round to 3 decimal places so that users can see ads that yield less than 0.1 BAT per view.
@jsecretan jsecretan added bug feature/ads OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 1, 2020
@tmancey
Copy link
Contributor

tmancey commented Jun 1, 2020 •
edited
Loading

Will be fixed by #10027

@tmancey tmancey self-assigned this Jun 1, 2020
@tmancey tmancey closed this as completed Jun 1, 2020
@tmancey tmancey added the closed/duplicate Issue has already been reported label Jun 1, 2020
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 13, 2020
@jsecretan jsecretan changed the title [Android] Expand estimated pending rewards to two decimal places [Android] Expand estimated pending rewards to three decimal places Jun 16, 2020
@tmancey tmancey removed this from the 1.12.x - Nightly milestone Jun 16, 2020
@tmancey tmancey reopened this Jun 16, 2020
@tmancey tmancey mentioned this issue Jun 16, 2020
Merged
32 tasks
@tmancey tmancey removed the closed/duplicate Issue has already been reported label Jun 16, 2020
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 16, 2020
@tmancey tmancey mentioned this issue Jun 16, 2020
Merged
4 tasks
@srirambv srirambv mentioned this issue Jul 7, 2020
Closed
10 tasks
This was referenced Jul 8, 2020
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Jul 23, 2020
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.11.98 x64 build

  • Verified estimated pending rewards show 3 decimal points
    image

Verification passed on Samsung Tab A with Android 10 running 1.11.98 x64 build

  • Verified estimated pending rewards show 3 decimal points
    image

@srirambv srirambv mentioned this issue Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
ARM Android ARM related issues enhancement feature/ads OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Expand estimated pending rewards to three decimal places brave/brave-core
4 participants
@jsecretan @tmancey @kjozwiak @srirambv