Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Follow up to #9975 - Make grammar consistent for titles and dropdowns on brave://settings/shields #10324

Closed
btlechowski opened this issue Jun 17, 2020 · 1 comment

Comments

@btlechowski
Copy link

Follow up to #9975 - The grammar changes are not reflected in locales other than us

Steps to Reproduce

  1. Run Brave in Polish (PL) locale
  2. Open brave://settings/shields

Actual result:

Changes to drop downs from #9975 are not reflected
image
image
image

Expected result:

Changes to drop downs from #9975 are reflected

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Ubuntu 18.04 LTS
Brave 1.12.28 Chromium: 83.0.4103.106 (Official Build) nightly (64-bit)
Revision ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @mkarolin @bsclifton @rebron @simonhong @karenkliu

@btlechowski
Copy link
Author

Verification passed on

Brave 1.24.16 Chromium: 89.0.4389.105 (Official Build) nightly (64-bit)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Verified changes from #9975 were applied

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants