[Desktop] Crash for balance call

[NejcZdovc]

[ 00 ] base::debug::DumpWithoutCrashing
[ 01 ] content::BrowserChildProcessHostImpl::OnMojoError
[ 02 ] mojo::(anonymous namespace)::RunErrorCallback
[ 03 ] mojo::core::(anonymous namespace)::RunMojoProcessErrorHandler(mojo::core::(anonymous namespace)::ProcessDisconnectHandler*, void (*)
[ 04 ] mojo::core::NodeChannel::NotifyBadMessage
[ 05 ] mojo::core::NodeController::NotifyBadMessageFrom
[ 06 ] mojo::core::Core::NotifyBadMessage
[ 07 ] mojo::internal::ReportValidationError
[ 08 ] bat_ledger::mojom::internal::BatLedger_FetchBalance_ResponseParams_Data::Validate
[ 09 ] mojo::internal::ValidateResponseGeneric
[ 10 ] mojo::MessageDispatcher::Accept
[ 11 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage
[ 12 ] mojo::internal::MultiplexRouter::Accept
[ 13 ] mojo::Connector::DispatchMessage
[ 14 ] mojo::Connector::ReadAllAvailableMessages
[ 15 ] base::TaskAnnotator::RunTask
[ 16 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl
[ 17 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork
[ 18 ] base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)
[ 19 ] pkey_x25519_derive$2e8add2861916223d98704c5544dee07
[ 20 ] base::MessagePumpGlib::Run
[ 21 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run
[ 22 ] base::RunLoop::Run
[ 23 ] performance_monitor::ProcessMonitor::StartGatherCycle
[ 24 ] ChromeBrowserMainParts::MainMessageLoopRun
[ 25 ] content::BrowserMainLoop::RunMainMessageLoopParts
[ 26 ] content::BrowserMainRunnerImpl::Initialize
[ 27 ] content::BrowserMainRunnerImpl::Run
[ 28 ] content::BrowserMain
[ 29 ] content::ContentMainRunnerImpl::Run
[ 30 ] content::ContentMainRunnerImpl::Initialize
[ 31 ] tcmalloc::ThreadCache::FetchFromCentralCache(unsigned int, int, void* (*)
[ 32 ] std::__1::__tree_const_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long> std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::find<base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >
[ 33 ] base::CommandLine::GetSwitchValueASCII
[ 34 ] content::ContentServiceManagerMainDelegate::IsEmbedderSubprocess
[ 35 ] service_manager::Main
[ 36 ] base::ScopedBlockingCall::~ScopedBlockingCall
[ 37 ] base::File::Stat
[ 38 ] base::internal::UncheckedScopedBlockingCall::~UncheckedScopedBlockingCall
[ 39 ] content::ContentMain
[ 40 ] ChromeMain

[LaurenWags]

Verified passed with

Brave | 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Allow FetchBalance to return an empty ledger::BalancePtr brave-core#6251
• Confirmed no crash when opening panel after relaunch. Confirmed no crashes listed in brave://crashes
• Note, panel did show "Join" messaging and an error on brave://rewards page. Confirmed with @zenparsing that this is expected (test plan does have user corrupt data) and the scope of this PR was just to address the crash, not recovery from corrupted data.

from logs:

[Aug 14, 2020, 9:08:05.1 AM:ERROR:wallet_balance.cc(45)] Payment ID is empty
[Aug 14, 2020, 9:08:05.1 AM:ERROR:promotion.cc(134)] Corrupted wallet

UI:

---

Verification passed on

Brave	1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision	d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6251
No crash

---

Verification passed on

Brave | 1.13.72 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

• Verified test plan from Allow FetchBalance to return an empty ledger::BalancePtr brave-core#6251
• Confirmed no crash when opening panel after relaunch. Confirmed no crashes listed in brave://crashes