Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 84.0.4147.105 to Chromium 84.0.4147.111 #11025

Closed
mkarolin opened this issue Jul 30, 2020 · 6 comments · Fixed by #11026 or brave/brave-core#6276
Closed

Upgrade from Chromium 84.0.4147.105 to Chromium 84.0.4147.111 #11025

mkarolin opened this issue Jul 30, 2020 · 6 comments · Fixed by #11026 or brave/brave-core#6276
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality QA/No QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified release-notes/include
Milestone
1.12.x - Release #1

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump. This bump only contains fixes for Android

https://chromium.googlesource.com/chromium/src/+log/84.0.4147.105..84.0.4147.111?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

No specific code changes in Brave (only line number changes in patches).
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jul 30, 2020
@mkarolin mkarolin self-assigned this Jul 30, 2020
This was referenced Jul 30, 2020
Merged
Merged
@srirambv
Copy link
Contributor

@mkarolin ok to remove Desktop label as you mentioned the fixes are only Android related?

@mkarolin
Copy link
Contributor Author

@srirambv: up to you. I am guessing there will be another bump before 1.12.x release on Desktop.

@srirambv
Copy link
Contributor

I think if there are no fixes for Desktop in the bump we can just have it as Android issue. Can always create one for desktop when it gets.

cc: @bsclifton @kjozwiak

@bsclifton
Copy link
Member

SGTM! 😄

This was referenced Aug 6, 2020
Merged
Merged
Merged
Merged
@mkarolin mkarolin added this to the 1.14.x - Nightly milestone Aug 7, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2020

Verification passed on Samsung Tab A
image

Verification passed on OnePlus 6T
image

This was referenced Aug 11, 2020
Closed
Closed
Closed
@kjozwiak
Copy link
Member

Labeling this one as QA/No in favour of #11153.

@kjozwiak kjozwiak removed the QA/Yes label Aug 12, 2020
@kjozwiak kjozwiak added the QA/No label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality QA/No QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
4 participants
@kjozwiak @bsclifton @srirambv @mkarolin