Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P2A questions in Brave Ads #11060

Closed
moritzhaller opened this issue Aug 3, 2020 · 1 comment · Fixed by brave/brave-core#6811
Closed

Add P2A questions in Brave Ads #11060

moritzhaller opened this issue Aug 3, 2020 · 1 comment · Fixed by brave/brave-core#6811
Assignees
@moritzhaller
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@moritzhaller
Copy link

moritzhaller commented Aug 3, 2020 •
edited
Loading

Add p2a questions in the service layer via weekly storage

  • Add total ad impressions question
  • Add total ad opportunities question
  • Add ad impressions per top level segment questions
  • Add ad opportunity per top level segment questions

report on the following top level segments:
architecture, arts & entertainment, automotive, business, careers, cell phones, crypto, education, family & parenting, fashion, folklore, food & drink, gaming, health & fitness, history, hobbies & interests, home, law, military, other, personal finance, pets, real estate, science, sports, technology & computing, travel, weather and untargeted
@moritzhaller moritzhaller added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads labels Aug 3, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Aug 20, 2020
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 2, 2020
Closed
@srirambv srirambv changed the title Fix recording P2A view-confirmations-metric in Ads [Desktop] Fix recording P2A view-confirmations-metric in Ads Sep 9, 2020
@moritzhaller moritzhaller changed the title [Desktop] Fix recording P2A view-confirmations-metric in Ads [Desktop] Add P2A questions in Brave Ads Oct 6, 2020
@moritzhaller moritzhaller mentioned this issue Oct 9, 2020
Merged
33 tasks
@tmancey tmancey mentioned this issue Oct 9, 2020
Closed
@tmancey tmancey changed the title [Desktop] Add P2A questions in Brave Ads Add P2A questions in Brave Ads Oct 9, 2020
@moritzhaller moritzhaller added this to the 1.18.x - Nightly milestone Oct 22, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#6811

Case 1: Untargeted ad
Verified logs for:

[9188:1176:1208/121045.537:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.TotalAdOpportunities has bucket count 9
[9188:1176:1208/121045.550:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.AdImpressionsPerSegment.untargeted has bucket count 9
[9188:1176:1208/121045.550:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.TotalAdImpressions has bucket count 9

Case 2: Targeted Ad
Verified logs for:

[7152:9020:1208/123107.490:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.AdOpportunitiesPerSegment.technologycomputing has bucket count 9
[7152:9020:1208/123107.490:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.AdOpportunitiesPerSegment.personalfinance has bucket count 9
[7152:9020:1208/123107.490:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.AdOpportunitiesPerSegment.fooddrink has bucket count 9
[7152:9020:1208/123107.490:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.TotalAdOpportunities has bucket count 9

Case 3: Disable P2A
Turn off ads

[12928:15952:1208/124431.386:VERBOSE1:ads_service_impl.cc(1657)] P2A histograms suspended
[12928:15952:1208/124431.386:VERBOSE1:ads_service_impl.cc(672)] Shutting down ads
[12928:15952:1208/124431.386:VERBOSE2:brave_p3a_service.cc(439)] BraveP3AService::OnHistogramChanged: histogram_name = Brave.P2A.TotalAdOpportunities Sample = 2147483646 bucket = 2147483646

Case 4: Re-enable Ads and make sure P2A/P3A works as expected

[4856:3048:1208/125046.694:VERBOSE1:ads_service_impl.cc(1657)] P2A histograms suspended
[4856:3048:1208/125046.694:VERBOSE1:ads_service_impl.cc(672)] Shutting down ads
[4856:3048:1208/125449.086:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.AdImpressionsPerSegment.untargeted has bucket count 9
[4856:3048:1208/125449.086:VERBOSE2:brave_p3a_service.cc(424)] P2A metric Brave.P2A.TotalAdImpressions has bucket count 9

@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moritzhaller moritzhaller

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Add P2A questions for ad opportunities and impressions brave/brave-core
3 participants
@tmancey @moritzhaller @btlechowski