Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] sometimes referrer doesn't display properly until page is reloaded - follow up to 8696 #11119

Open
LaurenWags opened this issue Aug 6, 2020 · 2 comments
Labels
feature/shields/referrer OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #8696

Initial navigation to https://fmarier.github.io/brave-testing/referrer-spoofing.html shows expected value in "cross-origin navigation (redirected via meta)" iframe. However, if you navigate away (clicking on a specific button on this page) and back, "cross-origin navigation (redirected via meta)" now incorrectly shows blank referrer until you refresh the page.

Steps to Reproduce

  1. Load https://fmarier.github.io/brave-testing/referrer-spoofing.html.
  2. Notice that "cross-origin navigation (redirected via meta)" is showing the expected value.
  3. Click on the "cross-origin navigation" link near the top of the page.
  4. Click the back button.
  5. Notice that "cross-origin navigation (redirected via meta)" is now showing a blank referrer instead of the expected value.

Actual result:

Screen Shot 2020-08-06 at 3 43 52 PM

If you refresh the page, it will show the expected result.

Expected result:

Screen Shot 2020-08-06 at 3 44 02 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.12.x yes
  • Can you reproduce this issue with the beta channel? 1.13.x yes
  • Can you reproduce this issue with the nightly channel? 1.14.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@fmarier
Copy link
Member

fmarier commented Aug 6, 2020

cc @iefremov

@btlechowski
Copy link

Reproduced on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

image

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/referrer OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.
Projects
Status: P3 Backlog
Development

No branches or pull requests

4 participants