Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Implement design for tipping banner #11393

Closed
NejcZdovc opened this issue Aug 24, 2020 · 1 comment · Fixed by brave/brave-core#6626
Closed

[Desktop] Implement design for tipping banner #11393

NejcZdovc opened this issue Aug 24, 2020 · 1 comment · Fixed by brave/brave-core#6626

Comments

@NejcZdovc
Copy link
Contributor

You can find designs in https://www.figma.com/file/EDGI52tfWG1ggC9ZYFguXy/tipping-banner-revamp-copy.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 9, 2020

Verification completed with

Brave	1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	macOS Version 10.14.6 (Build 18G6032)

Verified banner colors from linked Figma doc above

Screenshots banner - blue banner - green banner - orange banner - purple

Yellow background does not display, logged #12596

Verified test plan from brave/brave-core#6626

Case 1: One-time tipping - Unverified publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed default values of 1, 10, 100 BAT are displayed as tipping options.
Confirmed "add funds" link is displayed if there is not sufficient BAT in the wallet. Confirmed clicking on this link opens brave://rewards page, modal is not opened as per note in PR.
Confirmed able to select an amount and send tip. Since publisher is unverified, confirmed tip went to Pending list.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording.

1 time tip - unverified 1 time tip - unverified - add funds link 1 time tip - unverified - successful tip 1 time tip - unverified - tweet 1 time tip - unverified - pending list
Case 1: One-time tipping - verified, not KYC'd publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed default values of 1, 10, 100 BAT are displayed as tipping options.
Confirmed "add funds" link is displayed if there is not sufficient BAT in the wallet. Confirmed clicking on this link opens brave://rewards page, modal is not opened as per note in PR.
Confirmed able to select an amount and send tip. Since publisher is not KYC'd, confirmed tip went to Pending list.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording.

1 time - non KYC 1time - non KYC - add funds link 1 time non KYC - successful tip tweet pending
Case 1: One-time tipping - KYC'd publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed publisher set values of 5, 10, 20 BAT are displayed as tipping options.
Confirmed publisher set background was displayed. Encountered #12057 as mentioned in PR for odd looking background.
Confirmed publisher set favicon/logo is shown.
Confirmed publisher set title is displayed.
Confirmed publisher set description is shown.
Confirmed able to select an amount and send tip. Since publisher is KYC'd, confirmed tip went thru.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording. Note, canned tweet does not mention "on GitHub" (or similar for other platforms). This was logged with #7698.

1 time tip KYC 1 time tip KYC successful 1 time tip tweet Screen Shot 2020-11-09 at 9 59 30 AM Screen Shot 2020-11-09 at 10 06 33 AM Screen Shot 2020-11-09 at 10 17 33 AM

Confirmed if KYC'd publisher does not have custom banner, the correct background, title, description, favicon, and amounts display (defaults):

Screen Shot 2020-11-09 at 10 09 44 AM
Case 2: Setting a monthly contribution - unverified publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

Screen Shot 2020-11-09 at 10 49 00 AM Screen Shot 2020-11-09 at 10 49 23 AM Screen Shot 2020-11-09 at 10 49 38 AM Screen Shot 2020-11-09 at 10 49 52 AM
Case 2: Setting a monthly contribution - verified, not KYC'd publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

Screen Shot 2020-11-09 at 11 06 27 AM Screen Shot 2020-11-09 at 11 06 54 AM Screen Shot 2020-11-09 at 11 08 38 AM Screen Shot 2020-11-09 at 11 08 48 AM
Case 2: Setting a monthly contribution - KYC'd publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

Screen Shot 2020-11-09 at 11 25 04 AM Screen Shot 2020-11-09 at 11 25 30 AM Screen Shot 2020-11-09 at 11 25 42 AM Screen Shot 2020-11-09 at 11 25 52 AM
Case 3: One-time tipping with existing monthly contribution - unverified publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.

Screen Shot 2020-11-09 at 12 49 25 PM

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.

Screen Shot 2020-11-09 at 12 50 35 PM

Confirmed "Cancel" flow:

  • Selecting "Cancel" matches designs from figma.
  • Selecting the "Confirm" button matches designs from figma.
  • Monthly contribution is removed.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.
Screen Shot 2020-11-09 at 12 50 46 PM Screen Shot 2020-11-09 at 12 51 22 PM Screen Shot 2020-11-09 at 12 51 51 PM

Confirmed "Change amount" flow:

  • Selecting "Change amount" matches designs from figma.
  • Able to select a new amount (or same amount) and "Set monthly contribution". The monthly contribution amount is updated on panel and brave://rewards.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not update the monthly contribution.
Screen Shot 2020-11-09 at 12 56 54 PM Screen Shot 2020-11-09 at 12 59 37 PM Screen Shot 2020-11-09 at 1 00 14 PM

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.

Brave	1.17.65 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	macOS Version 10.14.6 (Build 18G6032)
Case 3: One-time tipping with existing monthly contribution - verified, not KYC'd publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.

Screen Shot 2020-11-10 at 7 58 40 AM

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.

Screen Shot 2020-11-10 at 7 58 57 AM

Confirmed "Cancel" flow:

  • Selecting "Cancel" matches designs from figma.
  • Selecting the "Confirm" button matches designs from figma.
  • Monthly contribution is removed.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.
Screen Shot 2020-11-10 at 8 01 36 AM Screen Shot 2020-11-10 at 8 01 58 AM Screen Shot 2020-11-10 at 8 02 17 AM

Confirmed "Change amount" flow:

  • Selecting "Change amount" matches designs from figma.
  • Able to select a new amount (or same amount) and "Set monthly contribution". The monthly contribution amount is updated on panel and brave://rewards.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not update the monthly contribution.
Screen Shot 2020-11-10 at 8 04 11 AM Screen Shot 2020-11-10 at 8 04 53 AM

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.

Case 3: One-time tipping with existing monthly contribution - KYC'd publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.

Screen Shot 2020-11-10 at 8 31 20 AM

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.

Screen Shot 2020-11-10 at 8 32 05 AM

Confirmed "Cancel" flow:

  • Selecting "Cancel" matches designs from figma.
  • Selecting the "Confirm" button matches designs from figma.
  • Monthly contribution is removed.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.
Screen Shot 2020-11-10 at 8 33 57 AM Screen Shot 2020-11-10 at 8 34 48 AM Screen Shot 2020-11-10 at 8 35 11 AM

Confirmed "Change amount" flow:

  • Selecting "Change amount" matches designs from figma.
  • Able to select a new amount (or same amount) and "Set monthly contribution". The monthly contribution amount is updated on panel and brave://rewards.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not update the monthly contribution.
Screen Shot 2020-11-10 at 8 36 00 AM Screen Shot 2020-11-10 at 8 36 13 AM

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.

Case 4: In-line tipping - unverified publisher (Twitter, Reddit, GitHub)

Confirmed banner is shown when clicking on in-line tip button.
Twitter/Reddit - Confirmed monthly option is not displayed. TBD if GH should have it removed as well.
Twitter/Reddit - Confirmed social media post is displayed in the banner.
GitHub - Confirmed banner description is displayed. Media box is not available on GH per #5562.

Screen Shot 2020-11-10 at 8 53 32 AM Screen Shot 2020-11-10 at 8 54 04 AM Screen Shot 2020-11-10 at 8 59 59 AM

Confirmed one time tip is sent to Pending list for unverified publishers.

Screen Shot 2020-11-10 at 9 02 16 AM
Case 4: In-line tipping - verified, non-KYC'd publisher (Reddit)

Unable to check Twitter/GH as there is no verified, non-KYC'd publisher set up on staging env for these types.

Confirmed banner is shown when clicking on in-line tip button.
Reddit - Confirmed monthly option is not displayed.
Reddit - Confirmed social media post is displayed in the banner.

Screen Shot 2020-11-10 at 9 09 23 AM Screen Shot 2020-11-10 at 9 11 38 AM

Confirmed one time tip is sent to Pending list for verified, not KYC'd publishers.

Screen Shot 2020-11-10 at 9 12 00 AM
Case 4: In-line tipping - KYC'd publisher (Reddit)

Confirmed banner is shown when clicking on in-line tip button.
Twitter/Reddit - Confirmed monthly option is not displayed. TBD if GH should have it removed as well.
Twitter/Reddit - Confirmed social media post is displayed in the banner.
GitHub - Confirmed banner description is displayed.

Screen Shot 2020-11-10 at 9 49 24 AM Screen Shot 2020-11-10 at 9 49 46 AM Screen Shot 2020-11-10 at 9 51 42 AM

Confirmed one time tip is sent as expected.

Screen Shot 2020-11-10 at 9 53 24 AM Screen Shot 2020-11-10 at 9 53 38 AM Screen Shot 2020-11-10 at 9 54 05 AM Screen Shot 2020-11-10 at 9 54 19 AM Screen Shot 2020-11-10 at 9 54 29 AM

Verification passed on

Brave | 1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | Windows 10 OS Version 2004 (Build 19041.572)

Verified banner colors from linked Figma doc above

Screenshots

image
image
image
image
image
image

Encountered #12596

Verified test plan from brave/brave-core#6626

Case 1: One-time tipping - Unverified publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed default values of 1, 10, 100 BAT are displayed as tipping options.
Confirmed "add funds" link is displayed if there is not sufficient BAT in the wallet. Confirmed clicking on this link opens brave://rewards page, modal is not opened as per note in PR.
Confirmed able to select an amount and send tip. Since publisher is unverified, confirmed tip went to Pending list.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording.

image
image
image
image

Case 1: One-time tipping - verified, not KYC'd publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed default values of 1, 10, 100 BAT are displayed as tipping options.
Confirmed "add funds" link is displayed if there is not sufficient BAT in the wallet. Confirmed clicking on this link opens brave://rewards page, modal is not opened as per note in PR.
Confirmed able to select an amount and send tip. Since publisher is not KYC'd, confirmed tip went to Pending list.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording.

image
image
image
image
image

Case 1: One-time tipping - KYC'd publisher

Confirmed banner matches designs for one time tipping without credit card option.
Confirmed publisher set values of 5, 10, 20 BAT are displayed as tipping options.
Confirmed publisher set background was displayed. Encountered #12057 as mentioned in PR for odd looking background.
Confirmed publisher set favicon/logo is shown.
Confirmed publisher set title is displayed.
Confirmed publisher set description is shown.
Confirmed able to select an amount and send tip. Since publisher is KYC'd, confirmed tip went thru.
Confirmed clicking on the tweet button opened a new tab and drafted a tweet with expected wording. Note, canned tweet does not mention "on GitHub" (or similar for other platforms). This was logged with #7698.

image
image
image
image
image
image
image

Confirmed if KYC'd publisher does not have custom banner, the correct background, title, description, favicon, and amounts display (defaults):
image

Case 2. Setting a monthly contribution - unverified publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

image
image
image
image

Case 2: Setting a monthly contribution - verified, not KYC'd publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

image
image
image
image

Case 2: Setting a monthly contribution - KYC'd publisher

Confirmed Monthly is selected by default when choosing this option from the panel.
Confirmed tip amounts are displayed.
Confirmed able to set a monthly tip.
Confirmed tip completion display matches designs.
Confirmed monthly contribution in brave://rewards and on panel.

image
image
image
image

Case 3: One-time tipping with existing monthly contribution - unverified publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.
image

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.
image

Confirmed "Cancel" flow:

Selecting "Cancel" matches designs from figma.
Selecting the "Confirm" button matches designs from figma.
Monthly contribution is removed.
Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.

image
image
image

Confirmed "Change amount" flow:

  • Selecting "Change amount" matches designs from figma.
  • Able to select a new amount (or same amount) and "Set monthly contribution". The monthly contribution amount is updated on panel and brave://rewards.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not update the monthly contribution.

image
image
image
image

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.

Case 3: One-time tipping with existing monthly contribution - verified, not KYC'd publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.

image

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.
image

Confirmed "Cancel" flow:

Selecting "Cancel" matches designs from figma.
Selecting the "Confirm" button matches designs from figma.
Monthly contribution is removed.
Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.
image
image
image

Confirmed "Change amount" flow:

  • Selecting "Change amount" matches designs from figma.
  • Able to select a new amount (or same amount) and "Set monthly contribution". The monthly contribution amount is updated on panel and brave://rewards.
  • Selecting "One Time Tip" when on this screen or closing the banner without confirming does not update the monthly contribution.

image
image
image

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.

Case 3: One-time tipping with existing monthly contribution - KYC'd publisher

Confirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured.
image

Confirmed selecting the "Monthly" shows cancel/change UI.
Confirmed asterisk/messaging is hidden.
image

Confirmed "Cancel" flow:

Selecting "Cancel" matches designs from figma.
Selecting the "Confirm" button matches designs from figma.
Monthly contribution is removed.
Selecting "One Time Tip" when on this screen or closing the banner without confirming does not remove the monthly contribution.
image
image
image

Confirmed monthly contribution can still be removed from panel and brave://rewards.
Confirmed monthly contribution can still be modified from panel.
image

Case 4: In-line tipping - unverified publisher (Twitter, Reddit, GitHub)

Confirmed banner is shown when clicking on in-line tip button.
Twitter/Reddit - Confirmed monthly option is not displayed. TBD if GH should have it removed as well.
Twitter/Reddit - Confirmed social media post is displayed in the banner.
GitHub - Confirmed banner description is displayed. Media box is not available on GH per #5562.

image
image
image

Confirmed one time tip is sent to Pending list for unverified publishers.
image

Case 4: In-line tipping - verified, non-KYC'd publisher (Reddit)

Unable to check Twitter/GH as there is no verified, non-KYC'd publisher set up on staging env for these types.

Confirmed banner is shown when clicking on in-line tip button.
Reddit - Confirmed monthly option is not displayed.
Reddit - Confirmed social media post is displayed in the banner.

image
image

Confirmed one time tip is sent to Pending list for verified, not KYC'd publishers.
image

Case 4: In-line tipping - KYC'd publisher (Reddit)

Confirmed banner is shown when clicking on in-line tip button.
Twitter/Reddit - Confirmed monthly option is not displayed. TBD if GH should have it removed as well.
Twitter/Reddit - Confirmed social media post is displayed in the banner.
GitHub - Confirmed banner description is displayed.

image
image
image
image

Confirmed one time tip is sent as expected.
image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment