Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #6253: Automatically limit unwanted Brave Ads delivery #11617

Closed
btlechowski opened this issue Sep 8, 2020 · 1 comment · Fixed by brave/brave-core#6587
Closed

Follow up to #6253: Automatically limit unwanted Brave Ads delivery #11617

btlechowski opened this issue Sep 8, 2020 · 1 comment · Fixed by brave/brave-core#6587
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.16.x - Release #1

Comments

@btlechowski
Copy link

btlechowski commented Sep 8, 2020 •
edited
Loading

Follow up to #6253. The issue is still reproducible.

Description

While we currently have a feedback tool for ads which will limit delivery of downvoted ads, there have been many requests to limit delivery of repetitive ads so that the out of the box user experience is better. Eventually this will be handled by contextual "bandits" but in the mean time, we need some simple rules to help improve the situation.

The proposed rules are as follows

  1. If a user has a "landed" event on a page, do not show anything from that same campaign for another 48 hours.
  2. If a user has "dismissed" an ad twice in a row without clicking, also do not show anything from that same campaign for 48 hours.

Test plan

https://github.com/brave/internal/issues/719
@btlechowski btlechowski added bug enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 8, 2020
@btlechowski btlechowski mentioned this issue Sep 8, 2020
Closed
@tmancey tmancey changed the title [Desktop] Follow up to #6253: Automatically limit unwanted Brave Ads delivery Follow up to #6253: Automatically limit unwanted Brave Ads delivery Sep 8, 2020
@tmancey tmancey removed OS/Android Fixes related to Android browser functionality enhancement labels Sep 8, 2020
@tmancey tmancey self-assigned this Sep 8, 2020
@tmancey tmancey mentioned this issue Sep 8, 2020
Merged
32 tasks
@srirambv srirambv changed the title Follow up to #6253: Automatically limit unwanted Brave Ads delivery [Desktop] Follow up to #6253: Automatically limit unwanted Brave Ads delivery Sep 9, 2020
@tmancey tmancey added this to the 1.16.x - Nightly milestone Sep 9, 2020
@tmancey tmancey changed the title [Desktop] Follow up to #6253: Automatically limit unwanted Brave Ads delivery Follow up to #6253: Automatically limit unwanted Brave Ads delivery Sep 9, 2020
@btlechowski
Copy link
Author

btlechowski commented Oct 6, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/719#issue-696145308

Verified Limit landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad
Verified ad has landed

[18894:18894:1006/112344.101366:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 9dcadbf9-51c3-4235-97cb-99f75040a6bf, creative instance id 6cf074ff-9dbd-4539-bea7-8f1061a015d2 and landed

Verified unable to see the ad after 47 hours.

[21766:21766:1008/104324.123611:VERBOSE2:ads_impl.cc(965)] campaignId 1854d476-37b1-4116-baa5-cce6e5969ed7 has exceeded the frequency capping for landed

Verified Release landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad
Verified ad is shown

[22852:22852:1008/124514.991270:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 4be7646b-a2eb-470d-9063-103462848110
  parentUuid: ee0140b5-9043-4575-b6e6-01a9a3c55f6c
  creativeInstanceId: d175cdfd-57bf-46c3-9b00-89eed71c6ae5
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  campaignId: 1854d476-37b1-4116-baa5-cce6e5969ed7
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

Verified Limit landed ad - Untargated - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[23883:23883:1006/115141.391369:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 57770167-3b4f-4a4f-b051-8aca93a5b0fc, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours.

[24585:24585:1008/105622.541343:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit landed ad - Untargated - 2 Campaign, 1 CreativeSet, 1 Ad
Verified ad has landed

[25295:25295:1006/120524.602995:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id a3614a04-4902-4b7c-b3ab-6448a80b3d58, creative instance id d175cdfd-57bf-46c3-9b00-89eed71c6ae5 and landed

Verified ad from other campaign is shown

[26095:26095:1006/131534.164356:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 0f37db1f-b395-4519-a51e-e41b26a501e9
  parentUuid: 1af7e4c8-3827-492b-b96a-a48f707e106d
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  campaignId: a4a60766-1e40-4e63-802b-04e2973edbba
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

Verified ad from landed campaign are not shown and ads from the other campaign are shown

[26653:26653:1006/142134.232202:VERBOSE2:ads_impl.cc(965)] campaignId 1854d476-37b1-4116-baa5-cce6e5969ed7 has exceeded the frequency capping for landed
[26653:26653:1006/142134.232254:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 1 eligible ads before pacing
[26653:26653:1006/142134.232456:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 1 eligible ads after pacing
[26653:26653:1006/142134.232495:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[26653:26653:1006/142134.232531:VERBOSE1:ads_impl.cc(858)] Found 1 eligible ads
[26653:26653:1006/142134.232872:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 05cf1b32-6827-4321-af91-64f1b2358e8d
  parentUuid: 5333c88c-423e-4cd4-aad1-515a4af6ad09
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  campaignId: a4a60766-1e40-4e63-802b-04e2973edbba
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1

Verified Limit landed ad - Parent only - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[27265:27265:1006/122815.470080:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 4722ef59-5afd-4e12-8da1-a903040a708a, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and landed

Verified unable to see the ad after 47 hours.

[28025:28025:1008/113040.661660:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit landed ad - Parent-Child - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[28728:28728:1006/124556.240506:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 2b75e33c-ea7d-4e10-b615-7bc9460a2a7e, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours.

[29444:29444:1008/114708.626450:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit ads dismissed in a row
Verified ad was dismissed

[30052:30052:1006/125427.345438:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 49265a80-44a7-4517-b4f2-dcdf86f7c3c8, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and dismiss

Verified ad was dismissed the second time

[30052:30052:1006/135710.869631:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 26011e5e-40b5-40c7-aed6-788ea7248ebb, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and dismiss

Verified unable to see the ad after 47 hours.

[30598:30598:1008/115836.669474:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for dismissed

Verified Release dismissed ads
Verified ad is shown

[31159:31159:1008/135939.683908:VERBOSE1:ads_impl.cc(858)] Found 2 eligible ads
[31159:31159:1008/135939.684507:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 09d7cacc-6aed-47a7-8ed3-6ad269f579b0
  parentUuid: a774d32c-8b2a-4392-8c23-882a7154c6b8
  creativeInstanceId: c2e47aa0-054e-47d0-98bb-b3328d4ccb7a
  creativeSetId: c1a44f78-8298-48cb-9457-3d03e888454a
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

Verified passed with

Brave	1.16.57 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
Revision	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from https://github.com/brave/internal/issues/719

Limit landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad

Verified ad landed:

[13317:775:1009/093425.374864:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id bb8867cd-1804-4239-b801-533f3637a124, creative instance id d175cdfd-57bf-46c3-9b00-89eed71c6ae5 and landed

Verified unable to see the ad after 47 hours

[13420:775:1011/083403.792706:VERBOSE2:ads_impl.cc(965)] campaignId 1854d476-37b1-4116-baa5-cce6e5969ed7 has exceeded the frequency capping for landed
Release landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad

Verified ad is shown:

[13470:775:1011/094019.032396:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: a4f085c4-40e8-451c-9984-1655fd518e5d
  parentUuid: 7a7e21c8-a16f-4000-bff9-5ea550a1585b
  creativeInstanceId: 6cf074ff-9dbd-4539-bea7-8f1061a015d2
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  campaignId: 1854d476-37b1-4116-baa5-cce6e5969ed7
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 2
  body: Campaign 1 CreativeSet 1 Ad 2
  targetUrl: https://travala.com/
Limit landed ad - Untargated - 1 Campaign, 2 CreativeSet, 1 Ad

Verified ad is landed:

[13671:775:1009/115856.882926:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id f57ce1af-7adc-4637-b74e-479649fc27a6, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours:

[13740:775:1011/110103.980960:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed
Limit landed ad - Untargated - 2 Campaign, 1 CreativeSet, 1 Ad

Verified ad has landed:

[13787:775:1009/121241.925233:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 28d16e89-8058-4dbe-9520-7975a5b079b1, creative instance id d175cdfd-57bf-46c3-9b00-89eed71c6ae5 and landed

Verified ad from other campaign is shown:

[13787:775:1009/131346.710807:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 1 eligible ads before pacing
[13787:775:1009/131346.710858:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 1 eligible ads after pacing
[13787:775:1009/131346.710903:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13787:775:1009/131346.710952:VERBOSE1:ads_impl.cc(858)] Found 1 eligible ads
[13787:775:1009/131346.711149:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: f778107a-e119-4763-a46e-eb0ebe1b0090
  parentUuid: e3c69845-4371-4d58-afca-faf80bdcd7f5
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  campaignId: a4a60766-1e40-4e63-802b-04e2973edbba
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1

Verified ad from landed campaign are not shown and ads from the other campaign are shown:

[13787:775:1009/141551.216397:VERBOSE2:ads_impl.cc(965)] campaignId 1854d476-37b1-4116-baa5-cce6e5969ed7 has exceeded the frequency capping for landed
[13787:775:1009/141551.216457:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 1 eligible ads before pacing
[13787:775:1009/141551.216494:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 1 eligible ads after pacing
[13787:775:1009/141551.216528:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13787:775:1009/141551.216573:VERBOSE1:ads_impl.cc(858)] Found 1 eligible ads
[13787:775:1009/141551.216846:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 38c6d066-d359-4585-bdb0-2bc5742746f9
  parentUuid: 5b2c054a-a512-4329-9cba-7cc61bfdd3fb
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  campaignId: a4a60766-1e40-4e63-802b-04e2973edbba
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1
Limit landed ad - Parent only - 1 Campaign, 2 CreativeSet, 1 Ad

Verified ad has landed:

[13869:775:1009/124611.605748:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 6d386e49-d95a-4513-9c20-924d31d71b4f, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and landed

Verified unable to see the ad after 47 hours:

[13919:775:1011/114735.282249:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed
Limit landed ad - Parent-Child - 1 Campaign, 2 CreativeSet, 1 Ad

Verified ad has landed:

[13971:775:1009/125525.878092:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 11ac754e-e1b0-483a-9bda-f96315825c3a, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours:

[14015:775:1011/115705.306225:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed
Limit ads dismissed in a row

Verified ad was dismissed:

[14066:775:1009/131451.844782:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id e9ce9941-cfb8-43e9-ad17-c5ac0c43796e, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and dismiss

Verified ad was dismissed the second time:

[14066:775:1009/141635.810267:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id b1dde842-10dd-4a3b-a5b9-ce73cf03e00a, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and dismiss

Verified unable to see the ad after 47 hours:

[14127:775:1011/121834.377636:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for dismissed
Release dismissed ads

Verified ad is shown:

[14127:775:1011/142028.158950:VERBOSE1:ads_impl.cc(858)] Found 2 eligible ads
[14127:775:1011/142028.159194:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: a0a70c58-e73d-4312-aab7-75137104629f
  parentUuid: 7cc5d01f-3b25-437e-b25f-2885651aa6d0
  creativeInstanceId: c2e47aa0-054e-47d0-98bb-b3328d4ccb7a
  creativeSetId: c1a44f78-8298-48cb-9457-3d03e888454a
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1

Verification passed on


Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified Limit landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad
Verified ad has landed

[18576:15688:1013/180317.945:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id ab60589e-298b-4ae3-8a6b-ff4c3bd69cd8, creative instance id 6cf074ff-9dbd-4539-bea7-8f1061a015d2 and landed

Verified unable to see the ad after 47 hours.

[18012:15172:1015/191539.639:VERBOSE2:ads_impl.cc(965)] campaignId 1854d476-37b1-4116-baa5-cce6e5969ed7 has exceeded the frequency capping for landed

Verified Release landed ad - Untargated - 1 Campaign, 1 CreativeSet, 2 Ad
Verified ad is shown

[3460:17468:1013/213942.076:VERBOSE1:ads_impl.cc(1115)] Ad notification shown:
  uuid: 59dab080-39f8-47ed-a004-635fda3791c1
  parentUuid: 25e8b073-8ea6-4e3a-bbd4-f33d82a8f2d2
  creativeInstanceId: 6cf074ff-9dbd-4539-bea7-8f1061a015d2
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  campaignId: 1854d476-37b1-4116-baa5-cce6e5969ed7
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 2
  body: Campaign 1 CreativeSet 1 Ad 2
  targetUrl: https://travala.com/
[3460:17468:1013/213942.083:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 59dab080-39f8-47ed-a004-635fda3791c1 and 6cf074ff-9dbd-4539-bea7-8f1061a015d2 creative instance id
[3460:17468:1013/213942.083:VERBOSE1:confirmations.cc(123)] Confirm ad:
  creativeInstanceId: 6cf074ff-9dbd-4539-bea7-8f1061a015d2
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  campaignId: 1854d476-37b1-4116-baa5-cce6e5969ed7
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Verified Limit landed ad - Untargated - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[21456:10632:1013/212624.573:VERBOSE1:ads_impl.cc(1471)] Successfully redeemed unblinded token with confirmation id 761c7230-7054-4887-b2c7-091390857445, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours.

[13024:6896:1016/191417.816:VERBOSE2:ads_impl.cc(965)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit landed ad - Untargated - 2 Campaign, 1 CreativeSet, 1 Ad

Verified ad has landed

[2292:24604:1014/203721.914:VERBOSE1:ads_impl.cc(1463)] Successfully redeemed unblinded token with confirmation id 7d712bc4-e185-43b5-8d96-35a468105468, creative instance id db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 and landed

Verified ad from other campaign is shown

[2292:24604:1014/203701.804:VERBOSE1:ads_impl.cc(1108)] Ad notification shown:
  uuid: 07b8b8d7-a0b6-4d31-8000-58716bf8f6f9
  parentUuid: 63679f92-3e60-4d2e-86e4-f6a584bc5a17
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  campaignId: a4a60766-1e40-4e63-802b-04e2973edbba
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

Verified ad from landed campaign are not shown and ads from the other campaign are shown

[4616:25580:1014/214846.277:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[4616:25580:1014/214846.278:VERBOSE1:ads_impl.cc(851)] Found 1 eligible ads
[4616:25580:1014/214846.279:VERBOSE1:ads_impl.cc(1108)] Ad notification shown:
  uuid: 3c32ce61-aba8-4180-8670-3a05004749e6
  parentUuid: 474b957a-0834-4f84-933e-bf503f615b62
  creativeInstanceId: d175cdfd-57bf-46c3-9b00-89eed71c6ae5
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  campaignId: 1854d476-37b1-4116-baa5-cce6e5969ed7
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

Verified Limit landed ad - Parent only - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[9356:720:1014/220427.176:VERBOSE1:ads_impl.cc(1463)] Successfully redeemed unblinded token with confirmation id 66c33779-3c96-4280-8fbd-24ec225fc856, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and landed

Verified unable to see the ad after 47 hours.

[25024:17164:1016/210801.047:VERBOSE2:ads_impl.cc(958)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit landed ad - Parent-Child - 1 Campaign, 2 CreativeSet, 1 Ad
Verified ad has landed

[20036:2548:1014/221230.859:VERBOSE1:ads_impl.cc(1463)] Successfully redeemed unblinded token with confirmation id 808d3f1a-a248-467b-b491-0e94d8f77c56, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and landed

Verified unable to see the ad after 47 hours.

[6372:3836:1016/211528.644:VERBOSE2:ads_impl.cc(958)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for landed

Verified Limit ads dismissed in a row
Verified ad was dismissed

[25244:9208:1014/222934.633:VERBOSE1:ads_impl.cc(1463)] Successfully redeemed unblinded token with confirmation id 485ddd6b-c82f-4547-bc04-0b64c2b8751a, creative instance id 0d87dd71-eca5-4691-9dbc-fa7eeb9580db and dismiss

Verified ad was dismissed the second time

[24288:24100:1014/233437.160:VERBOSE1:ads_impl.cc(1463)] Successfully redeemed unblinded token with confirmation id a0af22f7-1e2b-4414-8d44-640c85948b81, creative instance id c2e47aa0-054e-47d0-98bb-b3328d4ccb7a and dismiss

Verified unable to see the ad after 47 hours.

[12912:16684:1016/213818.768:VERBOSE2:ads_impl.cc(958)] campaignId dbd742cc-7bcf-47c8-aeed-5a8be10c7261 has exceeded the frequency capping for dismissed

Verified Release dismissed ads
Verified ad is shown

[12372:9468:1015/014408.500:VERBOSE1:ads_impl.cc(851)] Found 2 eligible ads
[12372:9468:1015/014408.500:VERBOSE1:ads_impl.cc(1108)] Ad notification shown:
  uuid: 1c3bf893-5c4e-4637-92d5-37eb73b4f5c1
  parentUuid: 95d35204-7a3c-45fb-b917-ebada33a4c99
  creativeInstanceId: c2e47aa0-054e-47d0-98bb-b3328d4ccb7a
  creativeSetId: c1a44f78-8298-48cb-9457-3d03e888454a
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/

@LaurenWags LaurenWags mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes follow up to #6253: Automatically limit unwanted Brave Ads delivery brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya