Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and phrasing improvements in chrome://rewards #1169

Closed
echosa opened this issue Sep 18, 2018 · 3 comments
Closed

Typos and phrasing improvements in chrome://rewards #1169

echosa opened this issue Sep 18, 2018 · 3 comments

Comments

@echosa
Copy link

echosa commented Sep 18, 2018

There are typos on chrome://rewards:

The wallet and created here

should be

The wallet created here

screen shot 2018-09-18 at 4 56 09 am


Do you know that you've been paying for the web content with your data for the digital ads? You didn't have a voice in it and worse, you're exposed to privacy and security risks

would be better worded without the extra "the"-s, and needs a period at the end, and a comma

Do you know that you've been paying for web content with your data through digital ads? You didn't have a voice in it and, worse, you're exposed to privacy and security risks.

screen shot 2018-09-18 at 5 00 21 am


Get paid for the ads. And pay directly the favorite content creators at your will. That way, they can grow and continue delivering the content that delights you.

shouldn't start a sentence with "and" and could use some rewording:

Get paid for the ads, and directly pay your favorite content creators at your will. That way, they can grow and continue delivering the content that delights you.

screen shot 2018-09-18 at 5 02 07 am


Set budget and browse normally. Your favorite sites get paid automatically.

would be better as

Set a budget […]

or

Set your budget […]

screen shot 2018-09-18 at 5 03 30 am


A simple way to support content creators. Set monthly allowance and browse normally. Your favorite sites (content sites only) receive your contributions automatically. You can exclude sites from funding here.

Again, this would be better with

Set a monthly allowance […]

or

Set your monthly allowance […]

Also, there's an extra } after

Your monthly allowance gets divided based on your attention metric.}

screen shot 2018-09-18 at 5 10 14 am

@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 18, 2018
@srirambv srirambv added the needs-text-change This change requires some careful wording. label Sep 18, 2018
@srirambv
Copy link
Contributor

image
Your data is safe with our Shields doesn't relate to Ads here. Should be removed or appropriate text should be added

@srirambv
Copy link
Contributor

image
image

Bullet points should not have . at the end of sentence

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants