-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style Search section in settings #1186
Labels
closed/invalid
feature/global-settings
Settings at browser level independent of shields settings
feature/search
priority/P4
Planned work. We expect to get to it "soon".
Comments
rebron
added
feature/global-settings
Settings at browser level independent of shields settings
browser-laptop-parity
feature/search
labels
Sep 18, 2018
This was referenced Sep 27, 2018
separating out tasks and will file a separate issue for adding the private browsing options |
rebron
changed the title
style Search in settings and Add private browsing options
style Search in settings
Oct 3, 2018
28 tasks
rebron
added
priority/P2
A bad problem. We might uplift this to the next planned release.
and removed
browser-laptop-parity
labels
Jan 15, 2019
rebron
added
priority/P4
Planned work. We expect to get to it "soon".
and removed
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Jan 17, 2019
Closing out per discussion with @rossmoody. "Search engine" and "Search engine used in the address bar" are better labels and more descriptive, and styling change will be applied from other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed/invalid
feature/global-settings
Settings at browser level independent of shields settings
feature/search
priority/P4
Planned work. We expect to get to it "soon".
Description
see Design spec
Style Search section with Brave styling
re-label section - 'Search'
re-label in sidebar - 'Search'
Relabel 'Search engine used in the address bar' to 'Default search engine'.
Keep 'Manage search engines' section but use Brave styling.
Design
The text was updated successfully, but these errors were encountered: