Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Widget] Gemini widget doesn't handle translations very well in trade view #12154

Open
srirambv opened this issue Oct 15, 2020 · 1 comment
Open

[Widget] Gemini widget doesn't handle translations very well in trade view #12154

srirambv opened this issue Oct 15, 2020 · 1 comment
Labels
design A design change, especially one which needs input from the design team feature/widgets l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Gemini widget doesn't handle translations very well in trade view

Steps to Reproduce

  1. Set locale to non-EN region (used NL)
  2. Connect to Gemini widget
  3. Select Trade and select LINK token
  4. Select sell, text overlap for LINK and Buy

Actual result:

image

Expected result:

No overlapping text

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64 bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:
@srirambv srirambv mentioned this issue Oct 15, 2020
Closed
@ryanml ryanml assigned ryanml and unassigned ryanml Oct 16, 2020
@rebron rebron added design A design change, especially one which needs input from the design team priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Feb 5, 2021
@rebron
Copy link
Collaborator

rebron commented Feb 5, 2021

cc: @jamesmudgett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team feature/widgets l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebron @ryanml @srirambv