Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #10946 - Incorrect Japanese translation for "Customize" under NTP #12194

Closed
GeetaSarvadnya opened this issue Oct 19, 2020 · 7 comments

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #10946 - Add padding to Customize text to accomodate translations

Steps to Reproduce

  1. Set OS locale to Japanese
  2. Install 1.17.39 nightly
  3. Open an NTP
  4. Customize text is translated as settings ( 設定 )

Actual result:

Customize text is translated as settings ( 設定 )
image

Expected result:

Customize text should be translated as Customize in Japanese

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.17.39 Chromium: 86.0.4240.99 (Official Build) nightly (64 ビット)
変更履歴 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS Windows 10 OS Version 1903 (Build 18362.1082)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron

@kjozwiak kjozwiak changed the title Follow up of #10946 - Add padding to Customize text to accomodate translations Follow up of #10946 - Incorrect Japanese translation for "Customize" Oct 20, 2020
@kjozwiak kjozwiak changed the title Follow up of #10946 - Incorrect Japanese translation for "Customize" Follow up of #10946 - Incorrect Japanese translation for "Customize" under NTP Oct 20, 2020
@kjozwiak
Copy link
Member

Reproduced on macOS 10.15.7 x64 using the following build:

Brave | 1.17.41 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)

スクリーンショット 2020-10-19 23 24 49

Screen Shot 2020-10-19 at 11 28 04 PM

@rebron mind taking a look at this one? Should we be using a different translation? Maybe we can ask for some help from someone who knows Japanese 👍

@chkk525
Copy link

chkk525 commented Oct 20, 2020

I translated it as "設定" as when it was translated as "customize" ("カスタマイズ"), it looks odd in the limited space. If we can expand the area, then we can call it as "カスタマイズ" instead.

@chkk525
Copy link

chkk525 commented Oct 20, 2020

Should I change the translation on Transifex?

@rebron
Copy link
Collaborator

rebron commented Oct 20, 2020

@chkk525 Yes, can change back to original text as #10946 was done to add some space to accommodate the proper string.

@chkk525
Copy link

chkk525 commented Oct 20, 2020

Done! @rebron

@rebron
Copy link
Collaborator

rebron commented Nov 23, 2020

@chkk525 Can you check to see if this is good on 1.17.73 and we can close out.

@rebron rebron self-assigned this Nov 23, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 23, 2020
@btlechowski btlechowski added this to the 1.24.x - Nightly milestone Mar 24, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.24.16 Chromium: 89.0.4389.105 (Official Build) nightly (64-bit)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants