Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome://cast/ shows empty page #1225

Closed
btlechowski opened this issue Sep 21, 2018 · 6 comments
Closed

chrome://cast/ shows empty page #1225

btlechowski opened this issue Sep 21, 2018 · 6 comments

Comments

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Steps to Reproduce

  1. Open chrome://cast/

IMPORTANT: This page is accessible through Cast Icon (located next to Brave Shield icon) -> Manage Cast Devices

image

Actual result:

Empty page is shown
Terminal error:
[10068:13160:0921/074535.542:ERROR:CONSOLE(0)] "Uncaught (in promise) Failed to load: src is not valid.", source: chrome://cast/ (0)

Expected result:

Similar to Chrome:
image

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7
@srirambv
Copy link
Contributor

Think this is invalid considering #763

cc: @bbondy

@bsclifton
Copy link
Member

bsclifton commented Sep 21, 2018

@srirambv that issue was closed saying:

Closing this issue since there are sufficient requests from users for cast support.

So I do think it should be working. I believe this is something that may need API keys to work though

Not having this support may affect webcompat- for example: #1227

@srirambv srirambv added this to the 2.x Backlog milestone Sep 21, 2018
@Brave-Matt
Copy link

@Brave-Matt
Copy link

Brave-Matt commented Sep 26, 2018

@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@srirambv
Copy link
Contributor

This page isn't listed any more under chrome://chrome-url. @kjozwiak could you check if this shows up when you are casting on a device? Since you were the only one who was able to test #209. We can close this issue if it doesn't show up while screen cast is in progress. I don't see the page on Chrome as well

@btlechowski
Copy link
Author

It seems to be fixed

Brave 0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 7 Service Pack 1 (Build 7601.24530)

I had to enable the cast feature through settings.
chrome://cast/ shows this page:
image

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants