Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] incorrect favicon for old reddit on panel #12301

Closed
LaurenWags opened this issue Oct 23, 2020 · 1 comment
Closed

[Desktop] incorrect favicon for old reddit on panel #12301

LaurenWags opened this issue Oct 23, 2020 · 1 comment

Comments

@LaurenWags
Copy link
Member

Description

If you visit a non-verified publisher on old.reddit.com and open the panel, the generic world icon displays. However, if you visit this same publisher on reddit.com, you get the generic reddit icon.

If the publisher is verified but does not have their own custom favicon (for the tipping banner), then they also get the generic world icon until you visit them on reddit.com.

Note, if the publisher has a custom favicon for the tipping banner, this is not an issue.

Steps to Reproduce

  1. Clean profile, enable rewards (staging env)
  2. Visit a non-verified publisher like old.reddit.com/user/brave_w0ts0n (non-verified publisher) or old.reddit.com/user/jsadler-brave (verified publisher without a custom tipping banner favicon).
  3. Wait a few seconds (due to reddit tipping banner taking ~5-8s to appear/display when using inline tipping under reddit #12241)
  4. Open panel.

Actual result:

old reddit brave_w0ts0n

Screen Shot 2020-10-23 at 3 13 34 PM

Expected result:

Screen Shot 2020-10-23 at 3 18 43 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.48 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes, reproduces on 1.15.x
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @emerick

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 20, 2022

Does not reproduce anymore with Rewards panel 2.0

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants