Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload new incognito tab resets DDG search button #1235

Closed
srirambv opened this issue Sep 21, 2018 · 1 comment · Fixed by brave/brave-core#529
Closed

Reload new incognito tab resets DDG search button #1235

srirambv opened this issue Sep 21, 2018 · 1 comment · Fixed by brave/brave-core#529

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018

Description

Reload new incognito tab resets DDG search button

Steps to Reproduce

  1. Clean install 0.55.5
  2. Open an incognito window
  3. Toggle DDG search, reload the new tab page, switch toggles back to off
  4. Do a search on DDG in incognito tab
  5. Open a new tab in incognito window, DDG is set as default search, reload new tab doesn't toggle the switch

Actual result:

This is the same behaviour on all platforms until a search is done on DDG
privatesearch1

On Windows 10 DDG search fails making it impossible to use DDG and reload always resets the switch
image

Expected result:

Once switch is enabled should be retained after page is reloaded

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.2 Chromium: 70.0.3538.16 (Official Build) (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS All

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

It also works the other way. Have DDG persist, open new private tab, turn DDG off and reload.
issue verified by @LaurenWags @kjozwiak on mac and @btlechowski on Windows 7

@srirambv
Copy link
Contributor Author

srirambv commented Oct 5, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified enabling DDG switch and reloading page didn't reset the setting
  • Verified after enabling DDG button typing a search term showed DuckDuckGo Search
  • Verified after disabling DDG button typing a search term showed Google Search
  • Verified enabling DDG button is retained across private browsing session
  • Verified enabling DDG button is retained across private tabs

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
  • Verified enabling DDG switch and reloading page didn't reset the setting
  • Verified after enabling DDG button typing a search term showed DuckDuckGo Search
  • Verified after disabling DDG button typing a search term showed Google Search
  • Verified enabling DDG button is retained across private browsing session
  • Verified enabling DDG button is retained across private tabs

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7
  • Verified enabling DDG switch and reloading page didn't reset the setting
  • Verified after enabling DDG button typing a search term showed DuckDuckGo Search
  • Verified after disabling DDG button typing a search term showed Google Search
  • Verified enabling DDG button is retained across private browsing session
  • Verified enabling DDG button is retained across private tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment