Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] opening the rewards panel on a "permalink" from reddit does not show the expected creator info #12357

Closed
LaurenWags opened this issue Oct 28, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

If you are on a post on reddit such as https://old.reddit.com/r/brave_browser/comments/jjlo4j/open_in_tor_prompt_when_visiting_nyt/ and you open the panel, it shows the creator info for the person who authored the post. In this case, that is tombstone2k:
Screen Shot 2020-10-28 at 8 30 11 AM

If you then click on "permalink" for one of the comments or open the permalink in a new tab, ex https://old.reddit.com/r/brave_browser/comments/jjlo4j/open_in_tor_prompt_when_visiting_nyt/gadday7/, and then open the panel, I'd expect the panel to show info for who authored the comment but it still shows info for who authored the post, in this case sgt_skinner:
Screen Shot 2020-10-28 at 8 33 07 AM

Note, on 1.16.x (no greaselion reddit tipping in this version) when you visit https://old.reddit.com/r/brave_browser/comments/jjlo4j/open_in_tor_prompt_when_visiting_nyt/, panel shows "reddit.com" not "tombstone2k on reddit". Similarly for visiting the permalink, panel shows "reddit.com".

Steps to Reproduce

  1. Navigate to a post on reddit such as https://old.reddit.com/r/brave_browser/comments/jjlo4j/open_in_tor_prompt_when_visiting_nyt/
  2. Open panel, confirm panel shows creator info for who authored the post
  3. Find a comment and click on the permalink or open permalink in a new tab
  4. Open panel

Actual result:

Screen Shot 2020-10-28 at 8 33 07 AM

Expected result:

panel would show comment author info not original thread author's info

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a (no greaselion reddit tipping on 1.16.x)
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick @NejcZdovc

@NejcZdovc
Copy link
Contributor

this is right now expected as we only show main comment publisher. Let's see if we want to add support for this one as well

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 20, 2022

Users will use the inline tipping buttons, rather than getting poster.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants